Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0: remove top level plots mapping support #37

Open
skshetry opened this issue May 22, 2023 · 5 comments
Open

3.0: remove top level plots mapping support #37

skshetry opened this issue May 22, 2023 · 5 comments

Comments

@skshetry
Copy link
Member

See iterative/dvc#9486.
@dberenbaum
Copy link
Contributor

How do we want to handle deprecations here? Do we want to version the schema? How will it work for users of older versions?

@skshetry
Copy link
Member Author

How will it work for users of older versions?

It won’t.

@skshetry
Copy link
Member Author

skshetry commented May 22, 2023 •
edited
Loading

I will not update this until we release 3.0.

@dberenbaum
Copy link
Contributor

How would 2.x users keep using it after that?

@skshetry
Copy link
Member Author

How would 2.x users keep using it after that?

We don't support any other versions than the most recent one. This time it's no different, 3.0 is a breaking change.

Besides, the user will only see a squiggly line in their IDE when plots are defined as a dict which has been long soft-deprecated if I remember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dberenbaum @skshetry