Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: get rid of test_clone #23

Open
7 tasks
skshetry opened this issue Dec 22, 2021 · 0 comments
Open
7 tasks

tests: get rid of test_clone #23

skshetry opened this issue Dec 22, 2021 · 0 comments
Labels

Comments

@skshetry
Copy link
Member

This clones a remote repo.

def test_clone(tmp_dir: TmpDir, matcher: Type[Matcher]):
progress = MagicMock()
url = "https://github.com/iterative/dvcyaml-schema"
Git.clone(url, "dir", progress=progress)
progress.assert_called_with(matcher.instance_of(GitProgressEvent))
assert (tmp_dir / "dir").exists()

We should replace this with tests testing:

  • clone with file://
  • clone local directory
  • clone with ssh
  • clone with http(s)
  • push_refspec with progress
  • clone with progress
  • fetch_refspec with progress
@skshetry skshetry added this to DVC Dec 22, 2021
@skshetry skshetry moved this to Backlog in DVC Dec 22, 2021
@skshetry skshetry removed this from DVC Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant