Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for secret renewal #7

Open
mcavoyk opened this issue Aug 24, 2020 · 2 comments
Open

Add support for secret renewal #7

mcavoyk opened this issue Aug 24, 2020 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mcavoyk
Copy link
Collaborator

mcavoyk commented Aug 24, 2020

Add field to ExternalSecret to control refresh period rather than relying on occasional controller resyncs.

Current design is to add the field refreshInterval of type time.Duration.

@mcavoyk mcavoyk changed the title Add support for ExternalSecret renewal Add support for secret renewal Aug 24, 2020
@mcavoyk mcavoyk added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 13, 2020
@ahmedmus-1A
Copy link

Hi @mcavoyk , is the current controller still does not support reconciling the secrets if updated in the backend ? any workarounds for that other than recreating the externalSecret resource ?

@mcavoyk
Copy link
Collaborator Author

mcavoyk commented Oct 26, 2020

Hi @mcavoyk , is the current controller still does not support reconciling the secrets if updated in the backend ? any workarounds for that other than recreating the externalSecret resource ?

This field is not currently supported, but all ExternalSecrets will be refreshed every controller resync period (~10 hours). If more immediate refresh is needed, right now the way to do that would be edit an annotation the ES which will cause the secret-manager to reconcile the secret and refresh the contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants