Templating is broken

[sbaier1]

Describe the bug:

The template patch field in the ExternalSecret CRD is not handled correctly in the controller. The internal datatype is wrong, making it impossible to use the field.

Setting a basic template leads to errors like this one:

Failed to watch *v1alpha1.ExternalSecret: failed to list *v1alpha1.ExternalSecret: v1alpha1.ExternalSecretList.Items: []v1alpha1.ExternalSecret: v1alpha1.ExternalSecret.Spec: v1alpha1.ExternalSecretSpec.Template: base64Codec: invalid input, error found in #10 byte of ...|template":{"type":"k|..., bigger context ...|n"}],"storeRef":{"name":"aws-secrets"},"template":{"type":"kubernetes.io/dockerconfigjson"}},"status|...

Expected behavior
Template should patch the resulting secret

Steps to reproduce the bug:
Set a template patch like the example above (JSON format: {"type":"kubernetes.io/dockerconfigjson"}})

Anything else we need to know?:
Filed a fix proposal PR #84

Environment details::

• Kubernetes version (e.g. v1.18.9): v1.17.12-eks-7684af
• Secret-Manager version (e.g. v0.2.0): current master branch
• SecretStore type(e.g. Vault vs AWS SecretManager): AWS secretmanager
• Install method (e.g. helm or static manifests): helm

/kind bug

[ahmedmus-1A]

Hello @sbaier1 , is there any updates in this issue ? i am stuck with the same problem

[sbaier1]

hey, well you can build and use my fork if you urgently need to fix it. (That's what I'm currently doing).

I originally considered getting that linked PR merged, but after checking in with the the external secrets community (see the slack link on the external secrets org), it doesn't seem worth the effort, since this project + the other external secrets controllers are currently in the process of merging into a single, unified controller so it doesn't seem worth the effort to contribute to this project at the moment. If the problem persists in the resulting controller, i will probably propose the changes there instead.

[devth]

Is itscontained/secret-manager officially merging into external-secrets/external-secrets? If so there should be a fat notice in this README.