Dev version of od causing simodels to fail

[Robinlovelace]

Changes to worse in reverse depends:

Package: simodels
Check: examples
New result: ERROR
Running examples in ‘simodels-Ex.R’ failed
The error most likely occurred in:

base::assign(".ptime", proc.time(), pos = "CheckExEnv")

Name: si_calculate

Title: Calculate flow using a pre-existing function

Aliases: si_calculate

** Examples

od = si_to_od(si_zones, si_zones, max_dist = 4000)
Converting p to centroids
1695 OD pairs remaining after removing those with a distance greater than 4000 meters:
15% of all possible OD pairs
Error in dplyr::inner_join():
! Join columns in x must be present in the data.
✖ Problem with O.
Backtrace:
▆

1. └─simodels::si_to_od(si_zones, si_zones, max_dist = 4000)
2. ├─dplyr::inner_join(od_df, origins_to_join, by = "O")
3. └─dplyr:::inner_join.data.frame(od_df, origins_to_join, by = "O")

4. └─dplyr:::join_mutate(...)
   

5.   └─dplyr:::join_cols(...)
   

6.     └─dplyr:::check_join_vars(by$x, x_names, by$condition, "x", error_call = error_call)
   

7.       └─rlang::abort(bullets, call = error_call)
   

Execution halted

Package: simodels
Check: re-building of vignette outputs
New result: ERROR
Error(s) in re-building vignettes:
...
--- re-building ‘simodels.Rmd’ using rmarkdown
--- finished re-building ‘simodels.Rmd’

--- re-building ‘sims-first-principles.Rmd’ using rmarkdown
** Processing: /home/hornik/tmp/CRAN/simodels.Rcheck/vign_test/simodels/vignettes/sims-first-principles_files/figure-html/inputs-1.png
288x288 pixels, 3x8 bits/pixel, RGB
Input IDAT size = 42755 bytes
Input file size = 42893 bytes

Trying:
zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 32240
zc = 9 zm = 8 zs = 1 f = 0
zc = 1 zm = 8 zs = 2 f = 0
zc = 9 zm = 8 zs = 3 f = 0
zc = 9 zm = 8 zs = 0 f = 5
zc = 9 zm = 8 zs = 1 f = 5
zc = 1 zm = 8 zs = 2 f = 5
zc = 9 zm = 8 zs = 3 f = 5

Selecting parameters:
zc = 9 zm = 8 zs = 0 f = 0 IDAT size = 32240

Output IDAT size = 32240 bytes (10515 bytes decrease)
Output file size = 32318 bytes (10575 bytes = 24.65% decrease)

Quitting from lines 99-108 [unnamed-chunk-3] (sims-first-principles.Rmd)
Error: processing vignette 'sims-first-principles.Rmd' failed with diagnostics:
ℹ In argument: O.
Caused by error:
! object 'O' not found
--- failed re-building ‘sims-first-principles.Rmd’