Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Width: Improve Sync Prompt Width functionality #85

Open
itsmartashub opened this issue Dec 9, 2024 · 0 comments
Open

Custom Width: Improve Sync Prompt Width functionality #85

itsmartashub opened this issue Dec 9, 2024 · 0 comments
Assignees
Labels
Customization: Width GPThemes Customization area related to Custom Widths Enhancement

Comments

@itsmartashub
Copy link
Owner

itsmartashub commented Dec 9, 2024

Current Behavior

  • Chat width: 49rem
  • Prompt field: 48rem
  • Issue: Visible 1rem misalignment between Chats and Prompt Field but all the custom width fn works as it should

Tried

  • Chat width default changed from 49rem to 48rem
  • Prompt field syncs automatically when widths match
  • Users must manually uncheck to disable syncing

Problem w/ "Tried"

Automatic width syncing creates unexpected behavior when widths happen to match, even if user hasn't enabled sync feature.

Proposed Solution

  • Maintain 48rem chat width default
  • Only sync prompt field width when user explicitly enables Sync with Chat option
  • Keep widths independent by default, regardless if they match
  • Add proper initialization to prevent auto-sync on load even if the user doesn't enable the auto-sync (it's because of the way how I'm currently maintaining the sync value like if chats width and prompt field are the same, automaticaly make it sync, and it's wrong)

Technical Changes Needed

  1. Update default chat width to 48rem
  2. Modify sync logic to only activate on explicit user action and update storage width settings object to attach this isSyncEnabled prop
  3. Initialize sync state as false despite matching widths

Testing Notes

  • Verify prompt width remains independent until sync enabled
  • Confirm manual sync toggle works correctly
  • Test different width combinations and page refresh
@itsmartashub itsmartashub self-assigned this Dec 9, 2024
@itsmartashub itsmartashub added the Customization: Width GPThemes Customization area related to Custom Widths label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customization: Width GPThemes Customization area related to Custom Widths Enhancement
Projects
None yet
Development

No branches or pull requests

1 participant