Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart - Passing Namespace not working #210

Open
ryanchauvin opened this issue May 29, 2024 · 2 comments
Open

Helm Chart - Passing Namespace not working #210

ryanchauvin opened this issue May 29, 2024 · 2 comments

Comments

@ryanchauvin
Copy link
Contributor

ryanchauvin commented May 29, 2024

Helm supports -n or --namespace string to set the namespace on Deployments, Services, etc.
This is not working on mc-router helm charts when doing --dry-run. It does deploy to the correct namespace, but you can not see the Namespace when doing --dry-run.

Could we have this fixed?

You can use namespace: {{ .Release.Namespace }} to accomplish this.

See examples below:

apiVersion: v1
kind: ServiceAccount
metadata:
name: example
namespace: {{ .Release.Namespace }}

apiVersion: apps/v1
kind: DaemonSet
metadata:
name: example-ds
namespace: {{ .Release.Namespace }}

@itzg itzg transferred this issue from itzg/mc-router May 30, 2024
@itzg
Copy link
Owner

itzg commented May 30, 2024

Submitting a PR to fix this would be great.

@ryanchauvin
Copy link
Contributor Author

I can do that, let me pull down the helm chart and do some testing.
I'll start with mc-router, then do the same for the rest.
I'll submit a PR once I validate it's working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants