Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a git-annex repo for data from Karolinska #16

Closed
5 tasks done
plbenveniste opened this issue May 28, 2024 · 30 comments
Closed
5 tasks done

Create a git-annex repo for data from Karolinska #16

plbenveniste opened this issue May 28, 2024 · 30 comments
Assignees
Labels

Comments

@plbenveniste
Copy link
Collaborator

plbenveniste commented May 28, 2024

The data is stored in duke:mri/karo/20200612_longitudinal
The steps are the following:

  • A git-annex repo should be created :
  • The data should be Bidsfied
  • The data should be pushed to the repo
  • A PR should be opened
  • The PR should be merged.

@jcohenadad What name should be used for the git-annex repo ? ms-karolinska ?

@mguaypaq Could you create the corresponding git-annex repo ?

This is related to issue 76. Creating this issue here to centralize the work on MS dataset.

@plbenveniste plbenveniste self-assigned this May 28, 2024
@jcohenadad
Copy link
Member

What name should be used for the git-annex repo ? ms-karolinska ?

given that karolinska has/will contribute to multiple datasets, coming from different studies, I think we need to specify them. Eg, this one could be called: ms-karolinska-2020

@plbenveniste
Copy link
Collaborator Author

Thanks @jcohenadad !

I am currently working on the bidsification of the data and facing a few issues. I am following the dcm2bids tutorial and ran the following commands:

conda activate dcm2bids
mkdir bids_karo
dcm2bids_scaffold -o bids_karo

The config file I created is the following (feedback is welcome on the suffixes chosen). It is stored in bids_karo/code

{
  "descriptions": [
    {
      "datatype": "anat",
      "suffix": "acq-MPRsag_T1w",
      "criteria": {
        "SeriesDescription": "t1_mpr_ns_sag_1mm_iso"
      } 
    },
    {
      "datatype": "anat",
      "suffix": "acq-sagDF_T2w",
      "criteria": {
        "SeriesDescription": "t2_space_dark-fluid_sag_REK_tra_3mm"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-sagDF_T2w",
      "criteria": {
        "SeriesDescription": "t2_space_dark-fluid_sag_REK_3mm_tra"
      }
    },
  
    {
      "datatype": "anat",
      "suffix": "acq-tseSag_T2w",
      "criteria": {
        "SeriesDescription": "t2_tse_sag_MS"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-sagP2_T2w",
      "criteria": {
        "SeriesDescription": "t2_space_sag_p2_iso_REK_tra_3mm"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-sagP2_T2w",
      "criteria": {
        "SeriesDescription": "t2_space_sag_p2_iso_REK_3mm_tra"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-me2d_T2w",
      "criteria": {
        "SeriesDescription": "t2_me2d_tra_p2_3mm"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-tse_T2w",
      "criteria": {
        "SeriesDescription": "t2_tse_tra"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-MPRsag_T1w",
      "criteria": {
        "SeriesDescription": "t1_mpr_ns_sag_1mm_iso_REK_1mm_tra"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-MPRsag_T1w",
      "criteria": {
        "SeriesDescription": "t1_mpr_ns_sag_1mm_iso_MPR_3mm_tra"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-MPRsagDF_T2w",
      "criteria": {
        "SeriesDescription": "t2_space_dark-fluid_sag_MPR_3mm_tra"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-MPRsagP2_T2w",
      "criteria": {
        "SeriesDescription": "t2_space_sag_p2_iso_MPR_3mm_tra"
      }
    }    
  ]
}

I created the following bash script to convert the dcm images to BIDS:

#!/bin/bash

# Check if the correct number of arguments is provided
if [ "$#" -ne 3 ]; then
    echo "Usage: $0 path/to/config.json path/to/output_dir path/to/dicom"
    exit 1
fi

# Get the config file, output directory, and DICOM directory from the command line arguments
config_file="$1"
output_dir="$2"
dicom_path="$3"

# Iterate over each folder in the DICOM directory
for folder in "$dicom_path"/SW1-*; do
  # Check if it is a directory
  if [ -d "$folder" ]; then
    # Extract participant and session info from the folder name
    # The folder bame is */SW1-1773_M0: the participant should be 1773 and the session M0
    subfolder="${folder##*/}"
    # Participant is the number after SW1- and before _
    participant="${subfolder#SW1-}"
    participant="${participant%%_*}"
    # Session is the letter after the _
    session="${subfolder##*_}"

    echo "Converting participant $participant session $session"

    # Define the DICOM directory
    dicom_dir="$folder"

    # Run dcm2bids
    dcm2bids -d "$dicom_dir" -p "$participant" -s "$session" -c "$config_file" -o "$output_dir" --bids_validate
  fi
done

echo "All conversions are done."

The script was ran using the following command:

bids_karo/code/convert_dcm2bids.sh bids_karo/code/dcm2bids_config.json  bids_karo/ 20200612_longitudinal/Karolinska_data.1/

However, some files don't have the field SeriesDescription and that was raised in the output :

INFO    | SIDECAR PAIRING
INFO    | No Pairing  <-  001_SW1-1875_M12_0_i00001
INFO    | No Pairing  <-  001_SW1-1875_M12_0_i00004
INFO    | No Pairing  <-  002_SW1-1875_M12_0
INFO    | No Pairing  <-  002_SW1-1875_M12_0a
INFO    | No Pairing  <-  003_SW1-1875_M12_0
INFO    | No Pairing  <-  003_SW1-1875_M12_0a
INFO    | No Pairing  <-  004_SW1-1875_M12_0
WARNING | NO PAIRING WAS FOUND. BIDS FOLDER "BIDS_KARO/SUB-1875/SES-M12" WON'T BE CREATED. CHECK YOUR CONFIG FILE.

You can find these files and logs in the following folder : duke/temp/plben/create_karo_gitannex/bids_karo/tmp_dcm2bids

What should I do ? How should I modify my config file to work with these files (I just showed an example but there are more that didn't work).

@jcohenadad @valosekj @NathanMolinier Any ideas ?

@plbenveniste
Copy link
Collaborator Author

plbenveniste commented May 30, 2024

After some investigation, I found that using "SequenceName" would work as well to create the file suffix.
The suffixes created are the following:

{
  "descriptions": [
    {
      "datatype": "anat",
      "suffix": "acq-sagMprage_T1w",
      "criteria": {
        "SequenceName": "*tfl3d1_16ns"
      } 
    },
    {
      "datatype": "anat",
      "suffix": "acq-sagTse_T2w",
      "criteria": {
        "SequenceName": "*tseR2d1rr19"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-me2d_T2w",
      "criteria": {
        "SequenceName": "*me2d1r4"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-Tse_T2w",
      "criteria": {
        "SequenceName": "*tseR2d1rs17"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-sagMprageDf_T2w",
      "criteria": {
        "SequenceName": "*spcir_278ns"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-sagMprageP2_T2w",
      "criteria": {
        "SequenceName": "*spcR_282ns"
      }
    },
    {
      "datatype": "anat",
      "suffix": "localiser",
      "criteria": {
        "SequenceName": "*fl2d1"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-sag_T1w",
      "criteria": {
        "SequenceName": "*spcir_257ns"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-epB0",
      "criteria": {
        "SequenceName": "*ep_b0"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-epB01000",
      "criteria": {
        "SequenceName": "*ep_b0_1000"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-epB1000t",
      "criteria": {
        "SequenceName": "*ep_b1000t"
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-cor_T1w",
      "criteria": {
        "SequenceName": "*h2d1_205",
        "ImageOrientationPatientDICOM": [1,0,0,0,0,-1]
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-sag_T1w",
      "criteria": {
        "SequenceName": "*h2d1_205",
        "ImageOrientationPatientDICOM": [0,1,0,0,0,-1]
      }
    },
    {
      "datatype": "anat",
      "suffix": "acq-ax_T1w",
      "criteria": {
        "SequenceName": "*h2d1_205",
        "ImageOrientationPatientDICOM": [1,0,0,0,1,0]
      }
    }
  ]
}

This should cover every-case in the dataset.

Only the following files were not transfered because they didn't look relevant:

  • 100_SW1-2128_M12_0a_ROI1.nii.gz
  • 101_SW1-2128_M12_0_ROI1.nii.gz
  • 103_SW1-2128_M12_0a_ROI1.nii.gz
  • 104_SW1-2128_M12_0_ROI1.nii.gz
  • 106_SW1-2128_M12_0a_ROI1.nii.gz
  • 107_SW1-2128_M12_0_ROI1.nii.gz
  • 100_SW1-2128_M12_0_ROI1.nii.gz
  • 102_SW1-2128_M12_0a_ROI1.nii.gz
  • 103_SW1-2128_M12_0_ROI1.nii.gz
  • 105_SW1-2128_M12_0a_ROI1.nii.gz
  • 106_SW1-2128_M12_0_ROI1.nii.gz
  • 108_SW1-2128_M12_0a_ROI1.nii.gz
  • 101_SW1-2128_M12_0a_ROI1.nii.gz
  • 102_SW1-2128_M12_0_ROI1.nii.gz
  • 104_SW1-2128_M12_0a_ROI1.nii.gz
  • 105_SW1-2128_M12_0_ROI1.nii.gz
  • 107_SW1-2128_M12_0a_ROI1.nii.gz
  • 108_SW1-2128_M12_0_ROI1.nii.gz

Feedback on the chosen conventions would be appreciated.

@plbenveniste
Copy link
Collaborator Author

The files contained in the 4 folders (Karolinska_data.1, Karolinska_data.2, Karolinska_data.3 and `Karolinska_data.4) were bidsified using the following line of code:

bids_karo/code/convert_dcm2bids.sh bids_karo/code/dcm2bids_config.json  bids_karo/ 20200612_longitudinal/Karolinska_data.1
bids_karo/code/convert_dcm2bids.sh bids_karo/code/dcm2bids_config.json  bids_karo/ 20200612_longitudinal/Karolinska_data.2
bids_karo/code/convert_dcm2bids.sh bids_karo/code/dcm2bids_config.json  bids_karo/ 20200612_longitudinal/Karolinska_data.3
bids_karo/code/convert_dcm2bids.sh bids_karo/code/dcm2bids_config.json  bids_karo/ 20200612_longitudinal/Karolinska_data.4

The metadata was added using the file code/add_dataset_metadata.py which takes data from the file 20200612_longitudinal/Karolinska_data_exported_2020.06.12\ .xlsx.

Everything is done and stored on /home/GRAMES.POLYMTL.CA/p119007/create_karo_gitannex/bids_karo.

Waiting for review of the conventions and the creation of the git-annex repo.

@mguaypaq
Copy link

I created the repo and gave @plbenveniste write access:
https://data.neuro.polymtl.ca/datasets/ms-karolinska-2020

@plbenveniste
Copy link
Collaborator Author

Some modifications were done in the .json file to make sure that DWI files are stored under /dwi and not /anat.
Also, the localizers were done for T1w images, therefore the contrast was added in the file name.

@plbenveniste
Copy link
Collaborator Author

plbenveniste commented Jun 11, 2024

The data was copied from the folder on romane to the git-annex folder using the following command :

cp -a bids-karo/. ms-karolinska-2020/

Useless files were removed (such as tmpdcm2bids). It was commited and then pushed to the remote branch.

Now ready for review!

@mguaypaq
Copy link

I left some review comments on the pull request:
https://data.neuro.polymtl.ca/datasets/ms-karolinska-2020/pulls/1

@plbenveniste
Copy link
Collaborator Author

@jcohenadad I am not sure if you are seeing the tags when I tagged you here.
Could you answer these questions please ?

Some files were deleted because they were missing bval and bvec.
Here is an example of image: (can be seen on the original post)
Do you think this is the right strategy ?
Also, what is the name and email address of the contact person for this dataset ?

@jcohenadad
Copy link
Member

Indeed I had missed the tagging (please note that I don't receive any notification when you tag me with this username-- because of an issue with my account i have to log in with julien-temp)-- thank you for the reminder.

@plbenveniste
Copy link
Collaborator Author

plbenveniste commented Jul 10, 2024

@mguaypaq The requested modifications were completed. 😃

@plbenveniste
Copy link
Collaborator Author

plbenveniste commented Jul 18, 2024

I am currently reviewing the suffixes of the image of the dataset.
Here are the possible combinations of seriesDescription, scanningSequence and SequenceName:

                       SeriesDescription ScanningSequence  SequenceName
0        t2_space_sag_p2_iso_MPR_3mm_tra               SE   *spcR_282ns
1                          t2_tse_sag_MS               SE  *tseR2d1rr19
2                     t2_me2d_tra_p2_3mm               GR      *me2d1r4
3      t1_mpr_ns_sag_1mm_iso_MPR_3mm_tra            GR\IR  *tfl3d1_16ns
4                             t2_tse_tra               SE  *tseR2d1rs17
5    t2_space_dark-fluid_sag_MPR_3mm_tra            SE\IR  *spcir_278ns
8      t1_mpr_ns_sag_1mm_iso_REK_1mm_tra            GR\IR  *tfl3d1_16ns
10   t2_space_dark-fluid_sag_REK_3mm_tra            SE\IR  *spcir_278ns
11       t2_space_sag_p2_iso_REK_3mm_tra               SE   *spcR_282ns
18                                                  GR\IR  *tfl3d1_16ns
19                                                     GR      *me2d1r4
20                                                  SE\IR  *spcir_278ns
21                                                     SE  *tseR2d1rr19
22                                                     SE   *spcR_282ns
23                                                     SE  *tseR2d1rs17
36                                                     GR        *fl2d1
72                                                  SE\IR  *spcir_257ns
137                                                    SE     *h2d1_205
380                t1_mpr_ns_sag_1mm_iso            GR\IR  *tfl3d1_16ns
384      t2_space_sag_p2_iso_REK_tra_3mm               SE   *spcR_282ns
385  t2_space_dark-fluid_sag_REK_tra_3mm            SE\IR  *spcir_278ns

@jcohenadad
Copy link
Member

jcohenadad commented Jul 19, 2024

Excellent, everything looks good, except "36: fl2d1" which is GR\IR instead of GR

@plbenveniste
Copy link
Collaborator Author

plbenveniste commented Jul 19, 2024

Just reminding, but this was extracted from the json sidecar (not written by me).
From your comment, I understand that *fl2d1 is a T1w instead of a T2w right?

EDIT: It cannot be MPRAGE since the images are anisotropic

@plbenveniste
Copy link
Collaborator Author

plbenveniste commented Jul 19, 2024

Here are the associated acq and suffix chosen for each:

                       SeriesDescription ScanningSequence  SequenceName      suffix-acq suffix-contrast
0        t2_space_sag_p2_iso_MPR_3mm_tra               SE   *spcR_282ns      acq-isoMPR             T2w
1                          t2_tse_sag_MS               SE  *tseR2d1rr19      acq-sagTse             T2w
2                     t2_me2d_tra_p2_3mm               GR      *me2d1r4          acq-ax          T2star
3      t1_mpr_ns_sag_1mm_iso_MPR_3mm_tra            GR\IR  *tfl3d1_16ns      acq-isoMpr          MPRAGE
4                             t2_tse_tra               SE  *tseR2d1rs17       acq-axTse             T2w
5    t2_space_dark-fluid_sag_MPR_3mm_tra            SE\IR  *spcir_278ns  acq-sagDfirMpr             T2w
8      t1_mpr_ns_sag_1mm_iso_REK_1mm_tra            GR\IR  *tfl3d1_16ns      acq-isoRek          MPRAGE
10   t2_space_dark-fluid_sag_REK_3mm_tra            SE\IR  *spcir_278ns  acq-sagDfirRek             T2w
11       t2_space_sag_p2_iso_REK_3mm_tra               SE   *spcR_282ns      acq-isoRek             T2w
18                                                  GR\IR  *tfl3d1_16ns         acq-iso          MPRAGE
19                                                     GR      *me2d1r4          acq-ax          T2star
20                                                  SE\IR  *spcir_278ns     acq-sagDfir             T2w
21                                                     SE  *tseR2d1rr19      acq-sagTse             T2w
22                                                     SE   *spcR_282ns         acq-iso             T2w
23                                                     SE  *tseR2d1rs17       acq-axTse             T2w
36                                                     GR\IR        *fl2d1   acq-localizer             T1w
72                                                  SE\IR  *spcir_257ns  acq-sagDfir257             T2w
137                                                    SE     *h2d1_205                             T2w
380                t1_mpr_ns_sag_1mm_iso            GR\IR  *tfl3d1_16ns         acq-iso          MPRAGE
384      t2_space_sag_p2_iso_REK_tra_3mm               SE   *spcR_282ns      acq-isoRek             T2w
385  t2_space_dark-fluid_sag_REK_tra_3mm            SE\IR  *spcir_278ns  acq-sagDfirRek             T2w

For the *h2d1_205, the acq param is chosen depending on the orientation of the image.

Working on the code to implement this now.

@plbenveniste
Copy link
Collaborator Author

Modifications were done with the script update_anat_suffixes.py and pushed to the development branch for review.

@plbenveniste
Copy link
Collaborator Author

Referencing this issue (issue 63) which is linked to the previous pre-processing of the karolinska data.

@plbenveniste
Copy link
Collaborator Author

Used command line to rename files from MPRAGE to T1w

find . -type f -name '*MPRAGE.*' -exec bash -c 'for file; do mv "$file" "${file/MPRAGE./T1w.}"; done' _ {} +

Pushed to git-annex

@plbenveniste
Copy link
Collaborator Author

Based on the comment neuropoly/data-management#63 (comment), I am reviewing the suffixes chosen for the karolinska dataset.

                       SeriesDescription ScanningSequence  SequenceName      suffix-acq suffix-contrast
0        t2_space_sag_p2_iso_MPR_3mm_tra               SE   *spcR_282ns      acq-isoMpr             T2w
1                          t2_tse_sag_MS               SE  *tseR2d1rr19      acq-sagTse             T2w
2                     t2_me2d_tra_p2_3mm               GR      *me2d1r4          acq-ax           MEGRE   Changed
3      t1_mpr_ns_sag_1mm_iso_MPR_3mm_tra            GR\IR  *tfl3d1_16ns      acq-isoMpr          MPRAGE
4                             t2_tse_tra               SE  *tseR2d1rs17       acq-axTse             T2w
5    t2_space_dark-fluid_sag_MPR_3mm_tra            SE\IR  *spcir_278ns         acq-sag           FLAIR   Changed
8      t1_mpr_ns_sag_1mm_iso_REK_1mm_tra            GR\IR  *tfl3d1_16ns      acq-isoRek          MPRAGE
10   t2_space_dark-fluid_sag_REK_3mm_tra            SE\IR  *spcir_278ns         acq-sag           FLAIR   Changed
11       t2_space_sag_p2_iso_REK_3mm_tra               SE   *spcR_282ns      acq-isoRek             T2w
18                                                  GR\IR  *tfl3d1_16ns         acq-iso          MPRAGE
19                                                     GR      *me2d1r4          acq-ax           MEGRE   Changed
20                                                  SE\IR  *spcir_278ns         acq-sag           FLAIR   Changed
21                                                     SE  *tseR2d1rr19      acq-sagTse             T2w
22                                                     SE   *spcR_282ns         acq-iso             T2w
23                                                     SE  *tseR2d1rs17       acq-axTse             T2w
36                                                  GR\IR        *fl2d1   acq-localizer             T1w
72                                                  SE\IR  *spcir_257ns      acq-sag257           FLAIR   Changed
137                                                    SE     *h2d1_205                             T2w
380                t1_mpr_ns_sag_1mm_iso            GR\IR  *tfl3d1_16ns         acq-iso          MPRAGE
384      t2_space_sag_p2_iso_REK_tra_3mm               SE   *spcR_282ns      acq-isoRek             T2w
385  t2_space_dark-fluid_sag_REK_tra_3mm            SE\IR  *spcir_278ns         acq-sag           FLAIR   Changed

Waiting for review from @jcohenadad and/or @NathanMolinier before applying on the dataset.

@NathanMolinier
Copy link

NathanMolinier commented Aug 28, 2024

Shouldn't we use T1w instead of MPRAGE for suffixes ?

It actually looks like you already change that here

@plbenveniste
Copy link
Collaborator Author

Great catch @NathanMolinier ! Thanks for the feedback ! Does the rest look good to you ?

@valosekj
Copy link
Member

Maybe we should use T2star instead of MEGRE?

@plbenveniste
Copy link
Collaborator Author

Maybe we should use T2star instead of MEGRE?

I used MEGRE because of what I found in this comment : neuropoly/data-management#63 (comment)

@valosekj
Copy link
Member

And maybe acq-isoRek --> acq-iso? (no need for Rek?)

@valosekj
Copy link
Member

Maybe we should use T2star instead of MEGRE?

I used MEGRE because of what I found in this comment : neuropoly/data-management#63 (comment)

Interesting! But T2star still seems to be a valid BIDS suffix, right? Although, BIDS recommends updating it to T2starw:

image

If we agree to use MEGRE for T2* images, we will need to update most of our existing datasets.

@plbenveniste
Copy link
Collaborator Author

I think we decided to use MEGRE in this case because of the specific sequence used: which is me2d. I guess for other T2star images it would depend on the sequence used.

@plbenveniste
Copy link
Collaborator Author

And maybe acq-isoRek --> acq-iso? (no need for Rek?)

For this one, I kept REK because otherwise I would have two identical names for different images (because of `acq-isoMpr.

@plbenveniste
Copy link
Collaborator Author

plbenveniste commented Sep 10, 2024

Here is the final version of the suffix chosen:

                       SeriesDescription ScanningSequence  SequenceName      suffix-acq suffix-contrast
0        t2_space_sag_p2_iso_MPR_3mm_tra               SE   *spcR_282ns      acq-isoMpr             T2w
1                          t2_tse_sag_MS               SE  *tseR2d1rr19      acq-sagTse             T2w
2                     t2_me2d_tra_p2_3mm               GR      *me2d1r4          acq-ax           MEGRE   Changed
3      t1_mpr_ns_sag_1mm_iso_MPR_3mm_tra            GR\IR  *tfl3d1_16ns      acq-isoMpr             T1w   Changed
4                             t2_tse_tra               SE  *tseR2d1rs17       acq-axTse             T2w
5    t2_space_dark-fluid_sag_MPR_3mm_tra            SE\IR  *spcir_278ns         acq-sag           FLAIR   Changed
8      t1_mpr_ns_sag_1mm_iso_REK_1mm_tra            GR\IR  *tfl3d1_16ns      acq-isoRek             T1w   Changed
10   t2_space_dark-fluid_sag_REK_3mm_tra            SE\IR  *spcir_278ns         acq-sag           FLAIR   Changed
11       t2_space_sag_p2_iso_REK_3mm_tra               SE   *spcR_282ns      acq-isoRek             T2w 
18                                                  GR\IR  *tfl3d1_16ns         acq-iso             T1w   Changed
19                                                     GR      *me2d1r4          acq-ax           MEGRE   Changed
20                                                  SE\IR  *spcir_278ns         acq-sag           FLAIR   Changed
21                                                     SE  *tseR2d1rr19      acq-sagTse             T2w
22                                                     SE   *spcR_282ns         acq-iso             T2w
23                                                     SE  *tseR2d1rs17       acq-axTse             T2w
36                                                  GR\IR        *fl2d1   acq-localizer             T1w
72                                                  SE\IR  *spcir_257ns      acq-sag257           FLAIR   Changed
137                                                    SE     *h2d1_205                             T2w
380                t1_mpr_ns_sag_1mm_iso            GR\IR  *tfl3d1_16ns         acq-iso             T1w   Changed
384      t2_space_sag_p2_iso_REK_tra_3mm               SE   *spcR_282ns      acq-isoRek             T2w
385  t2_space_dark-fluid_sag_REK_tra_3mm            SE\IR  *spcir_278ns         acq-sag           FLAIR   Changed

Thanks for the feedback everybody !
I will do the modifications now!

@plbenveniste
Copy link
Collaborator Author

Modifications done :

python code/update_anat_suffixes.py -i ~/update_gitannex/ms-karolinska-2020/

The PR is ready for review 😃

@plbenveniste
Copy link
Collaborator Author

The PR was merged ! PR 1

Thanks @mguaypaq 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants