Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Icon variation using a secondary icon #6

Open
ypapouin opened this issue May 17, 2023 · 3 comments
Open

[IMP] Icon variation using a secondary icon #6

ypapouin opened this issue May 17, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@ypapouin
Copy link

Simple means "basic because it is not an image editor" :)

The main idea is to give the ability to have a secondary icon in order to give more context for a specific module (in case this module is just extending an existing app, not creating a new one).

  • The first step would be to select a basic shape that will remove content from the first icon (like Path > Difference in Inkscape)
    • This basic shape could be a rectangle, a triangle or a circle
    • You have presets to move it to 8 common anchors (4 corners, 4 middles)
    • You can also move it manually (using normalized value from -1.0 to 1.0 for horizontal/vertical positions)
    • You can resize it
  • Then you select a secondary icon that will appears centered in the middle of the basic shape
    • You can resize it
    • You can flip-it vertically/horizontally
      image
    • You can rotate it
      image

It implies that the original path of the primary icon should probably be kept somewhere before the path difference with the basic shape.

image

@ivantodorovich
Copy link
Owner

Hi @ypapouin

Thanks for the suggestion!

Just to be clear, if the user doesn't want to use one of the icons from Iconify, the alternative is to build a custom icon in an external tool like Inkscape and then drag the .svg file to the icon builder.

I agree it's not super convenient, but IMO the actual icon glyph design is out of the scope of this tool. We trust other tools are way better at this than this one.

I do like the idea of having some basic modifications for the glyph. Currently we only support modifying its size, but it would be simple to support flipping and rotating it. I don't think it adds much value, though. It's not common to do these operations on odoo application icons.

Having said that, I welcome contributions if you wanna give it a try.

On a side note, this tool will stop being useful soon, with the new 'Milk' theme in Odoo 17.0. Icons are completely different and will no longer require a background.

@ivantodorovich ivantodorovich added the enhancement New feature or request label May 18, 2023
@ypapouin
Copy link
Author

@ivantodorovich

Thanks for the information about the Milk theme (argh), but this rainbow/unicorn/playschool combo is not for me, I will stay with the latest 16.0 theme :)

I can see that your app is a react one, I would like to experiment but I never used this framework.
If I clone your repo, what are the main steps to build it from src ?

@ivantodorovich
Copy link
Owner

Hi @ypapouin

You need nodejs and npm installed.

Then simply run npm install to pull the dependencies.

And npm start every time you work on the project - it launches a server and a browser, and constantly watches for file changes so it reloads automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants