Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Build.IsInvalid with Failed status #169

Open
applejag opened this issue Feb 28, 2022 · 2 comments
Open

Replace Build.IsInvalid with Failed status #169

applejag opened this issue Feb 28, 2022 · 2 comments
Labels
chore Routine task, refactoring, or other changes not affecting end-users directly. prio/1 Low priority. "Nice to have"

Comments

@applejag
Copy link
Contributor

applejag commented Feb 28, 2022

We have duplication of ways to represent a similar process.

A while ago we introduced Build.IsInvalid to be used when a build fails to start but has already been created in the database, such as if the Jenkins call fails.

Suggest instead to only use the Failed build status. Migration could be done easily by a single SQL query of something like:

UPDATE build SET status=3 WHERE isInvalid=1

And then drop the isInvalid column

We could introduce a FailedStatus column that is a free-text field of why it failed, and then we could use that to show to the user the reason for it failing (when we know the cause, such as connection refused on contacting Jenkins).

@applejag applejag added prio/1 Low priority. "Nice to have" chore Routine task, refactoring, or other changes not affecting end-users directly. labels Feb 28, 2022
@applejag applejag transferred this issue from iver-wharf/wharf-cmd Mar 17, 2022
@applejag
Copy link
Contributor Author

Moved the issue. I think I accedentially created it in the wharf-cmd repo

@Alexamakans
Copy link
Member

Suggest maybe FailedReason instead of FailedStatus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Routine task, refactoring, or other changes not affecting end-users directly. prio/1 Low priority. "Nice to have"
Projects
None yet
Development

No branches or pull requests

2 participants