Added serialize function to activations.py #23432
Conversation
|
Thanks for contributing to Ivy! 😊👏 |
ivy-leaves
added
the
TensorFlow Frontend
|
@paulaehab Hey, can you please review my PR. Thank you. |
|
Hello @Nik-code first of all thanks for contributing but could you please add test for the fucntion you will find more details in this link : (https://unify.ai/docs/ivy/overview/deep_dive/ivy_frontends_tests.html) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
Added tests for the serialize function
|
Hey @paulaehab , I have added the relevant tests for the serialize function in the test_activation.py file. I've added them with compliance to the documentation you mentioned here, please review the new commit for the changes, thanks. |
| {"2.13.0 and below": ("float16", "float32", "float64")}, | ||
| "tensorflow", | ||
| ) | ||
| def serialize(func, custom_objects=None): |
There was a problem hiding this comment.
we need to adhere the Tensorflow frontend names for arguments it was in documentation (activation, use_legacy_format=False) you could have a look here (https://www.tensorflow.org/api_docs/python/tf/keras/activations/serialize )
|
@paulaehab |
|
Hey @Nik-code could you please follow the instruction of this page https://unify.ai/docs/ivy/overview/contributing/the_basics.html#todo-list-issues to add issue related to serialize function in #1569 and add the issue number in comment instead of ( Closes #1569) |
|
@paulaehab |
Hello @abdul-rehman18 I am very sorry @Nik-code had already made the function and he just forget to add issue with function name , also it was my fault that I didn't get it I am sorry for that could you pick another function and again sorry for this mistake |
|
no problem sir @paulaehab |
|
|
Hey @paulaehab , thank you for the suggestions. I'll make sure to make the requested changes soon and post the commit 😊 |
|
Close #25851 |
|
Hey @paulaehab I have made a new commit changing the function description according to the TensorFlow documentation, Also I have correctly created a sub-task which I mentioned above that is now referenced in #1569 |
|
Hey @Nik-code thanks for contributing look great for me 😄 |
PR Description
Related Issue
Closes #1569