feat: added bernoulli_ #23680
feat: added bernoulli_ #23680
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
ivy-leaves
added
the
PyTorch Frontend
|
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
|
@Mr-Niraj-Kulkarni Excitedly looking forward to get it reviewed and merged! |
|
@jaskiratsingh2000. Can you please add the tests for it as well. |
|
@Mr-Niraj-Kulkarni will it be possible that I could submit a test from another PR? |
No. You must write the tests and the test should pass for the implemented function. That is complete procedure for implementing a function. Please take help of the tests implemented in the file to implement the test. Also refer the ivy documentation for test implementation. Once done please let me know I will review it then. Thanks |
|
@Mr-Niraj-Kulkarni I have implemented the test for the specific function. Can you please review it now? |
|
I will take it from here |
|
@Mr-Niraj-Kulkarni After tremendous debugging I figured out that the test case for which it is failing is not from the code I have implemented it seems to be a whole from other. So I feel this is good to go |
| dtype_and_x=helpers.dtype_and_values( | ||
| available_dtypes=helpers.get_dtypes("valid"), | ||
| ), | ||
| test_with_out=st.just(True), |
There was a problem hiding this comment.
Let me know if that works
There was a problem hiding this comment.
@umairjavaid you mean removing "test_with_out=st.just(True)" line right?
There was a problem hiding this comment.
@jaskiratsingh2000 Yup we'll have to remove this
| dtype_and_x=helpers.dtype_and_values( | ||
| available_dtypes=helpers.get_dtypes("valid"), | ||
| ), | ||
| test_with_out=st.just(True), |
There was a problem hiding this comment.
@jaskiratsingh2000 Yup we'll have to remove this
| "input": x[0], | ||
| }, | ||
| method_input_dtypes=input_dtype, | ||
| method_all_as_kwargs_np={"generator": x[1], "out": x[2]}, |
There was a problem hiding this comment.
The "out" kwarg should also be removed here. Thanks
|
Closing this PR since it has been stale for more than 2 weeks now. |
#22976