Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add end-of-file-fixer check. #23752

Closed
Sai-Suraj-27 opened this issue Sep 17, 2023 · 0 comments · Fixed by #23577
Closed

[Feature Request]: Add end-of-file-fixer check. #23752

Sai-Suraj-27 opened this issue Sep 17, 2023 · 0 comments · Fixed by #23577
Assignees

Comments

@Sai-Suraj-27
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I found that the end-of-file-fixer check is very common (recommended) and used in most of the big Python based organizations including Paddle, scikit-learn, mindsbd, jax, pandas, etc. So, it will be nice to have it in our codebase.

Benefits
It can help to prevent errors, as some programs may rely on the presence of a newline character at the end of a file.
It can help to ensure that files are consistent with each other, as all files in a repository should have the same end-of-file style.

Describe the solution you'd like
The solution would be to update the .pre-commit-config.yaml file by adding this check. Similar to the checks I introduced in this Pull Request.

Describe alternatives you've considered

Additional context

@Sai-Suraj-27 Sai-Suraj-27 changed the title [Feature Request]: <Add end-of-file-fixer check> [Feature Request]: Add end-of-file-fixer check. Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants