Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added unsorted_segment_mean function #24984

Merged
merged 33 commits into from
Oct 29, 2023
Merged

feat: Added unsorted_segment_mean function #24984

merged 33 commits into from
Oct 29, 2023

Conversation

kamlishgoswami
Copy link
Contributor

Close #23779

github-actions[bot]
github-actions bot reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@kamlishgoswami
Copy link
Contributor Author

Hi @rishabgit ,
Can u please review the PR and let me know if any changes are needed? Thanks

@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request PaddlePaddle Backend Developing the Paddle Paddle Backend. Ivy Functional API labels Sep 20, 2023
@kamlishgoswami kamlishgoswami changed the title Added unsorted_segment_mean feat: Added unsorted_segment_mean Sep 20, 2023
@kamlishgoswami kamlishgoswami changed the title feat: Added unsorted_segment_mean feat: Added unsorted_segment_mean funtion Sep 20, 2023
@kamlishgoswami kamlishgoswami changed the title feat: Added unsorted_segment_mean funtion feat: Added unsorted_segment_mean function Sep 20, 2023
rishabgit
rishabgit suggested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@rishabgit rishabgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I added comments as appropriate and also, the lint test seems to be failing. Could you please use pre-commit for a quick fix?
Feel free to re-request review after making these changes, thanks! 😄

ivy/data_classes/array/experimental/creation.py Show resolved Hide resolved
ivy/data_classes/container/experimental/creation.py Show resolved Hide resolved
ivy/functional/ivy/experimental/creation.py Show resolved Hide resolved
rishabgit
rishabgit suggested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@rishabgit rishabgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, attached the error message I'm seeing on torch backend
image

ivy/data_classes/array/experimental/creation.py Show resolved Hide resolved
ivy/data_classes/container/experimental/creation.py Show resolved Hide resolved
@rishabgit
Copy link
Contributor

Also, could you please take care of the lint errors? Thanks! 😄

@kamlishgoswami kamlishgoswami force-pushed the kamlish branch 3 times, most recently from 2a48f40 to 45d2734 Compare October 12, 2023 21:02
@kamlishgoswami
Copy link
Contributor Author

kamlishgoswami commented Oct 12, 2023 •
edited
Loading

Also, could you please take care of the lint errors? Thanks! 😄

Done. 😁

lint-error fix

I ran the pre-commit commands on my local and all pre-commit tests are passed but GitHub showing an error in lint-code.

@kamlishgoswami
Copy link
Contributor Author

Hi, attached the error message I'm seeing on torch backend image

The unsorted_segment_mean function implementation seems correct. But might be a problem with other functions already done in the backend. It also shows an error in my local. Could you please check Rishab what actually the problem is?
Thank you in advance! 😀

@kamlishgoswami kamlishgoswami force-pushed the kamlish branch 2 times, most recently from f040646 to 317f6bb Compare October 13, 2023 19:56
@kamlishgoswami
Copy link
Contributor Author

Hi @rishabgit,

Can u please review the PR and let me know if any changes are needed? Thanks

@rishabgit
Copy link
Contributor

Also, could you please take care of the lint errors? Thanks! 😄

Done. 😁
lint-error fix

I ran the pre-commit commands on my local and all pre-commit tests are passed but GitHub showing an error in lint-code.

This might be because your branch is outdated. Could you please update to latest Ivy and try pre-commit again?

Hi, attached the error message I'm seeing on torch backend image

The unsorted_segment_mean function implementation seems correct. But might be a problem with other functions already done in the backend. It also shows an error in my local. Could you please check Rishab what actually the problem is? Thank you in advance! 😀

Testing results ideally shouldn't change on different machines. Could you please join our discord and ask in appropriate channel if you need further help on this?

Also, I see a lot of merge conflicts which I suppose would be resolved when you update to latest Ivy but thought of bringing that up 😅

rishabgit
rishabgit suggested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@rishabgit rishabgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added review in previous comment :)

@kamlishgoswami kamlishgoswami force-pushed the kamlish branch 2 times, most recently from ca1aeb1 to a4e9425 Compare October 24, 2023 23:58
@kamlishgoswami
Copy link
Contributor Author

Hello @rishabgit,

I have fixed the lint and merge conflicts. Please let me know what is required to merge this PR. Thank you!!  😄

@rishabgit rishabgit merged commit a84b6b6 into ivy-llc:main Oct 29, 2023
132 of 137 checks passed
@kamlishgoswami kamlishgoswami deleted the kamlish branch October 30, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@guillesanbri guillesanbri Awaiting requested review from guillesanbri

@rishabgit rishabgit Awaiting requested review from rishabgit

Assignees

@rishabgit rishabgit

Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API PaddlePaddle Backend Developing the Paddle Paddle Backend.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unsorted_segment_mean
4 participants
@kamlishgoswami @rishabgit @ivy-leaves @ivy-branch