(refactor): pass fn as first argument to nested_map to follow convention and remove redundant logic from nested functions #23538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbarrett98
requested review from
sherry30,
CatB1t and
vedpatwardhan
as code owners
ivy-leaves
added
Array API
|
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
vedpatwardhan
approved these changes
Sep 14, 2023
ivy/functional/ivy/gradients.py
Outdated
| @@ -279,16 +277,16 @@ def _process_func_ret_and_grads(func_ret, grads, retain_grads): | |||
| def _variable(x): | |||
| x = ivy.to_native(x, nested=True) | |||
| ret = ivy.nested_map( | |||
| x, current_backend(x).variable, include_derived=True, shallow=False | |||
| current_backend(x).variable, x, include_derived=True, shallow=False | |||
| ) | |||
| return ivy.nested_map(ret, ivy.to_ivy, include_derived=True) | |||
There was a problem hiding this comment.
could you please change the function call here as well? Rest seems good to merge, thanks @mattbarrett98 😄
mattbarrett98
changed the title
vedpatwardhan
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
lgtm! Feel free to merge, thanks @mattbarrett98 😄
(I went through most of the failing tests in the CI and they don't seem to be related to these changes)
iababio
pushed a commit
to iababio/ivy
that referenced
this pull request
Sep 27, 2023
…ion and remove redundant logic from nested functions (ivy-llc#23538)
druvdub
pushed a commit
to druvdub/ivy
that referenced
this pull request
Oct 14, 2023
…ion and remove redundant logic from nested functions (ivy-llc#23538)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleaning up of nested functions, removed functionality relating to
max_depthandextra_nest_typeswhich just seem to be there for the sake of it, and have no uses in any repos.Also changing the order of arguments in
nested_mapto pass the function to apply in first, which is consistent with python'smapfunction, and basically any other equivalent function you can find (for example https://www.tensorflow.org/api_docs/python/tf/nest/map_structure , https://jax.readthedocs.io/en/latest/_autosummary/jax.tree_util.tree_map.html).Let me know your thoughts @vedpatwardhan