Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(numpy_frontends): implement real_if_close function. #23677

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

akshatvishu
Copy link
Contributor

@akshatvishu akshatvishu commented Sep 15, 2023

PR Description

Previously, the implementation was held off due to ivy's lack of support for complex numbers. Added unit tests to ensure the function behaves as expected.

Related Issue

Close #23676

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Previously, the implementation was held off due to ivy's lack of support for complex numbers.
Added unit tests to ensure the function behaves as expected.
@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Sep 15, 2023
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sherry30 sherry30 merged commit 1a2b0c6 into ivy-llc:main Sep 18, 2023
201 of 279 checks passed
@akshatvishu
Copy link
Contributor Author

akshatvishu commented Sep 18, 2023

lgtm!

(୨୧•͈∀•͈)⊃━ᵗʱᵃᵑᵏઽ for the review @sherry30 !

@akshatvishu akshatvishu deleted the np_real_if branch September 18, 2023 10:18
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add real_if_close to numpy frontends
3 participants