Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix dtype issues in torch.tensor frontend tests #28408

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jacksondm33
Copy link
Contributor

@jacksondm33 jacksondm33 commented Feb 24, 2024

PR Description

Fixes issues present in several frontend tests for torch.tensor:

  • fixes incorrect dtype lists passed to the test_frontend_method helper
  • matches sampled data types to those supported by each method according to the PyTorch docs

Related Issue

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Feb 24, 2024
@jacksondm33 jacksondm33 force-pushed the fix_torch_tensor_dtype_issues branch from eb92035 to 70a3bd6 Compare February 27, 2024 16:51
@Ishticode
Copy link
Contributor

Thank you for the PR. Please mark the PR ready for review when done. Thank you :)

@jacksondm33 jacksondm33 force-pushed the fix_torch_tensor_dtype_issues branch 3 times, most recently from 6511429 to 2bc90bf Compare April 13, 2024 21:17
@jacksondm33 jacksondm33 force-pushed the fix_torch_tensor_dtype_issues branch from 16aa74a to 939ac06 Compare April 14, 2024 00:29
@jacksondm33 jacksondm33 marked this pull request as ready for review April 14, 2024 04:01
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants