Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: How to properly specify patcher-args? #559

Open
Lassie111 opened this issue Dec 26, 2024 · 12 comments
Open

Question: How to properly specify patcher-args? #559

Lassie111 opened this issue Dec 26, 2024 · 12 comments

Comments

@Lassie111
Copy link

Lassie111 commented Dec 26, 2024

I want to specify revanced* custom header.
I tried -Oheader=revanced*, -Oheader=revanced\*, -Oheader="revanced*" and neither of them works. There are no patching errors but the header defaults to revanced*borderless.

Here is the whole config if it matters: https://github.com/Lassie111/revanced-magisk-module/blob/main/config.toml

@Lassie111
Copy link
Author

Probably it's a revanced issue - can't make it work with official CLI. (Or I'm making some stupid mistake)

@Lassie111 Lassie111 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2024
@Lassie111
Copy link
Author

Seems like the options are positional. -Oheader="revanced*" must be specified immediately after -e "Change header".
Temporary fix is to place "Change header" last, but I don't see what can we do if we want options for more than one patch?

@Lassie111 Lassie111 reopened this Dec 26, 2024
@TidalMist
Copy link
Contributor

patcher-args = "-e 'Change header' -Oheader=revanced* -e 'Theme' -OdarkThemeBackgroundColor=@color/m3_ref_palette_dynamic_neutral_variant6 -OlightThemeBackgroundColor=@color/m3_ref_palette_dynamic_neutral_variant98"

And dont add patch name to included-patches or excluded-patches that in patcher-args

@j-hc
Copy link
Owner

j-hc commented Dec 31, 2024

patcher-args = "-e 'Change header' -Oheader=revanced* -e 'Theme' -OdarkThemeBackgroundColor=@color/m3_ref_palette_dynamic_neutral_variant6 -OlightThemeBackgroundColor=@color/m3_ref_palette_dynamic_neutral_variant98"

And dont add patch name to included-patches or excluded-patches that in patcher-args

this is the correct way until I fix it properly.

@MusaBhai5
Copy link

MusaBhai5 commented Jan 2, 2025

How to add black icon in Anddea patch..correct way
OCustombrandingiconforYouTube=youtube_black

--enable Custom branding icon for YouTube --options=appIcon=xisr_yellow

@Dev-Hexx
Copy link

Dev-Hexx commented Jan 5, 2025

How Change youtube revanced extended icon with patcher-args?

@trmdi
Copy link

trmdi commented Jan 5, 2025

How Change youtube revanced extended icon with patcher-args?

patcher-args = "-e 'Custom branding name for YouTube' -OappName='YouTube Rvx' -e 'Custom branding icon for YouTube' -OappIcon='mmt'"

@Dev-Hexx
Copy link

Dev-Hexx commented Jan 5, 2025

How Change youtube revanced extended icon with patcher-args?

patcher-args = "-e 'Custom branding name for YouTube' -OappName='YouTube Rvx' -e 'Custom branding icon for YouTube' -OappIcon='mmt'"

Its Worked Thank You❤️

@Dev-Hexx
Copy link

Dev-Hexx commented Jan 6, 2025

patcher-args = "-e 'Visual preferences icons for YouTube' -OrvxSettingsMenuIcon='custom_branding_icon'" not working

@trmdi
Copy link

trmdi commented Jan 6, 2025

patcher-args = "-e 'Visual preferences icons for YouTube' -OrvxSettingsMenuIcon='custom_branding_icon'" not working

Wrong key.
https://github.com/inotia00/revanced-patches/blob/ee0a7b5443f221c08ff2c42cfd267c2891efac55/patches/src/main/kotlin/app/revanced/patches/youtube/layout/visual/VisualPreferencesIconsPatch.kt#L32

@saqie1393
Copy link

patcher-args = "-e 'Visual preferences icons for YouTube' -OrvxSettingsMenuIcon='custom_branding_icon'" not working

Wrong key. https://github.com/inotia00/revanced-patches/blob/ee0a7b5443f221c08ff2c42cfd267c2891efac55/patches/src/main/kotlin/app/revanced/patches/youtube/layout/visual/VisualPreferencesIconsPatch.kt#L32

-e 'Custom header for YouTube'-OcustomHeader='custom_branding_icon' how to fix this

@Dev-Hexx
Copy link

Dev-Hexx commented Jan 7, 2025

patcher-args = "-e 'Visual preferences icons for YouTube' -OrvxSettingsMenuIcon='custom_branding_icon'" not working

Wrong key. https://github.com/inotia00/revanced-patches/blob/ee0a7b5443f221c08ff2c42cfd267c2891efac55/patches/src/main/kotlin/app/revanced/patches/youtube/layout/visual/VisualPreferencesIconsPatch.kt#L32

-e 'Custom header for YouTube'-OcustomHeader='custom_branding_icon' how to fix this

In my case working well- -e 'Custom header for YouTube' -OcustomHeader='custom_branding_icon'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants