Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jme3-plugins loads MorphPrimitivesTest incorrectly #2110

Open
stephengold opened this issue Oct 14, 2023 · 2 comments
Open

jme3-plugins loads MorphPrimitivesTest incorrectly #2110

stephengold opened this issue Oct 14, 2023 · 2 comments
Labels
defect Something that is supposed to work, but doesn't. Less severe than a "bug"

Comments

@stephengold
Copy link
Member

I noticed a defect in GltfLoader while developing the MonkeyWrench library.

The test data is MorphPrimitivesTest from Khronos's glTF sample models.

Here's how it looks in CompareLoaders when "MorphPrimitivesTest/glTF/MorphPrimitivesTest.gltf" is loaded using jme3-plugins:

MorphPrimitivesTest

I believe the best approach to solve this issue will be:

  1. Add a MorphControl to every model with morph targets, even if there are no animation tracks.
  2. Initialize the morph state of each Geometry by invoking setMorphState() with the "weights" values in the glTF.
@stephengold stephengold added the defect Something that is supposed to work, but doesn't. Less severe than a "bug" label Oct 14, 2023
@riccardobl
Copy link
Member

Is this fixed by #2109 ?

@codex128
Copy link
Contributor

No, I've already tried MorphPrimitivesTest with #2109 and it still fails. I suspect this is because the gltf file does not explicitly define animations (unlike the MorphStressTest gltf).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something that is supposed to work, but doesn't. Less severe than a "bug"
Projects
None yet
Development

No branches or pull requests

3 participants