-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests about multibyte utf-8 characters #85
Comments
Currently it seems the jackrabbit adapter does not support emoticons like 😢. They fail at current function: jackalope-jackrabbit/src/Jackalope/Transport/Jackrabbit/Client.php Lines 1329 to 1331 in 7381adf
Seems like it has todo with the linked PR here in #55. Do you know anything about emoticon support in jackrabbit, do we need to add any encode / decode functions to support such a thing. |
i did not look into this in a long time. jackalope-jackrabbit runs against the old-ish jackrabbit and we never took the effort to upgrade to oak. not sure if the latest jackrabbit builds would support it. afaik people did things like url-encode on their node names to handle this. |
@dbu For the |
oh sorry, i misread what this is about. yes you could try what happens with a newer version of jackrabbit. if it works, then we can add some logic to only check this if jackrabbit is too old, or relax the check if more things work. |
we should test #84 - some of it in https://github.com/phpcr/phpcr-api-tests/ rather than just here.
we can also check if #55 or #65 can be relaxed now, they where about encoding problems.
/cc @OHB
The text was updated successfully, but these errors were encountered: