Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for new 'tick_double' field in 'jack_position_t' (fixes #8) #12

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SpotlightKid
Copy link
Collaborator

Fixes #8.

@SpotlightKid SpotlightKid added the enhancement New feature or request label Mar 27, 2022
@SpotlightKid SpotlightKid self-assigned this Mar 27, 2022
JACK_POSITION_MASK = (
JackPositionBBT
| JackPositionTimecode
| JackBBTFrameOffset
| JackAudioVideoRatio
| JackVideoFrameOffset
| JackTickDouble
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesnt match jack2 headers. JACK_POSITION_MASK in jack2 only has JackPositionBBT|JackPositionTimecode set. but that seems to be a jack2 issue.
then jack1/shared is missing the new JackTickDouble hmmm :/

not a problem for you, just noticed this inconsistency in jack headers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new JackTickDouble from 1.9.19
2 participants