Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin UI: Better response messages #49

Closed
jackjamieson2 opened this issue Dec 30, 2018 · 2 comments
Closed

Admin UI: Better response messages #49

jackjamieson2 opened this issue Dec 30, 2018 · 2 comments
Milestone
1.0

Comments

@jackjamieson2
Copy link
Owner

When searching for and following feeds there should be response messages indicating the following:

Search

  • No feeds found.
  • An unknown error occurred.
  • Timed out, please try again.

Follow

  • Success! Now following [feed]
  • Already following this feed in this channel.
  • Error: Failed to follow [feed].
  • Timed out, please try again.
@jackjamieson2 jackjamieson2 mentioned this issue Dec 30, 2018
Closed
@jackjamieson2 jackjamieson2 added this to the 1.0 milestone Feb 25, 2019
@jackjamieson2 jackjamieson2 mentioned this issue Mar 5, 2019
Closed
jackjamieson2 added a commit that referenced this issue May 30, 2019
@jackjamieson2
Improved error display when searching for feeds. Working toward #49
88dbc58
@jackjamieson2
Copy link
Owner Author

Thinking I might leave the messages as-is for now. I've added better messages for the search function.

In the case the case of the Follow function, this leads to the page reloading (so it can display the updated list of channels. In which case added a message is probably not necessary.

One potential issue is how to display errors if following fails for some reason, but at least for now I don't think that will come up in practice.

This is probably important to keep in mind when implementing websub (#33), because the follow action will be more complex and more likely to fail.

@jackjamieson2
Copy link
Owner Author

Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@jackjamieson2