Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hello_triangle.nim does't compile due to incorrect Use / UseProgram procedure name #2

Closed
Samulus opened this issue Dec 12, 2017 · 9 comments

Comments

@Samulus
Copy link
Contributor

Samulus commented Dec 12, 2017

I tried to compile the hello_triangle.nim example but I couldn't compile it due to this line.

The UseProgram wrapper procedure is actually just called Use (see here)

I would rename Use to be UseProgram but you could also change the procedure in hello_triangle.nim to be Use. I didn't a pull request because I'm not sure which you would prefer.

@jackmott
Copy link
Owner

Thanks, I probably changed the easygl wrapper and forget to go update hello_triangle, I'll fix it up tonight.

jackmott added a commit that referenced this issue Dec 13, 2017
@jackmott
Copy link
Owner

fixed

@dom96
Copy link

dom96 commented Dec 13, 2017

@jackmott Not sure if I mentioned this to you already, but it would be great if you followed the Nim code conventions. i.e. don't name your templates/procs with a capital letter at the start.

@jackmott jackmott reopened this Dec 13, 2017
@jackmott
Copy link
Owner

Ok I can fix that, but just noticed that nimble can no longer build because glm now requires nim 17.3 which I do not have, and I can't figure out how to request an older version.

requires "glm 0.2.0" doesn't seem to work.

@dom96
Copy link

dom96 commented Dec 13, 2017

You can try requires "glm#<commit_hash>" where commit_hash is the git commit hash of the version you want.

@jackmott
Copy link
Owner

that did it!
now to see if vs code's nim plugin has rename symbol

@jackmott
Copy link
Owner

@dom96 what is the best way to be able to compile all of the src files in the examples subdir at once? is there a way to set that up in the nimble file?

@dom96
Copy link

dom96 commented Dec 13, 2017

not currently. I mean you can write a task that does it, but Nimble doesn't have any default functionality for that.

@jackmott
Copy link
Owner

allright, lowerecased it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants