Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ecommerce-Provider] New provider needs access to the request / session / cookies #5

Open
andrewgadziksonos opened this issue Feb 1, 2022 · 1 comment

Comments

@andrewgadziksonos
Copy link

Hello!

I wanted to discuss potentially changing the type structure of ECommerceProvider so that the session is passed into it. I'm working on POCing with Salesforce Commerce Cloud, and they provider a series of APIs that require the app to generate an access token per session (think guest customers).

image

This API also requires that the app maintain a refresh token, and handle the use case where the access token expires. I wasnt quite sure where to put all of this logic, and it feels like it belongs in the provider implementation.

If there's a better Remix way of doing this, let me know.

@jacob-ebey
Copy link
Owner

Please check out the Hydrogen project for Remix ecomm best practices. I am not maintaining this and will probably never look at this repo again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants