Skip to content
This repository has been archived by the owner on Jul 30, 2020. It is now read-only.

Allow replacing fuzzy matching of completion/search results with prefix or substring matching. #551

Open
OlegOAndreev opened this issue Mar 23, 2018 · 4 comments

Comments

@OlegOAndreev
Copy link

Right now FilterAndSortCompletionResponse uses CaseFoldingSubsequenceMatch for filtering out the completion candidates. This can add too many candidates and it would be nice to have an option to limit the completions to prefix or substring matches.

@jacobdufault
Copy link
Owner

Sure, PR welcome :)

@ddovod
Copy link

ddovod commented Aug 27, 2018

Hey guys. I would like to make some effort to add a couple more matching options. But ofc I need some help from you.

  1. Is it okay to use external libraries (or just code chunks) with compatible licence?
    I would like to try these guys
    https://github.com/forrestthewoods/lib_fts/tree/master/code
    https://github.com/dsindex/autocomplete_libface
    https://github.com/xhochy/libfuzzymatch
    plus the most simple hand-written prefix matcher
  2. I've found out that include completion also works not very good. So does include completion use FilterAndSortCompletionResponse?

@jacobdufault
Copy link
Owner

So long as the library is relatively light-weight and self contained I'll most likely be fine with adding it.

Yea, include completion uses FilterAndSortCompletionResponse.

@ddovod
Copy link

ddovod commented Aug 28, 2018

Hi. Here's pull request. Still wip, but please take a look #786

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants