Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a responsive modal option #1425

Open
theGreener opened this issue May 25, 2022 · 2 comments · May be fixed by #1441
Open

Add a responsive modal option #1425

theGreener opened this issue May 25, 2022 · 2 comments · May be fixed by #1441
Assignees
Labels

Comments

@theGreener
Copy link

Is your feature request related to a problem? Please describe.
On large screen devices modals don't make full use of the available space for them, this results in labels for form fields overflowing onto new lines making it difficult to read the label

Describe the solution you'd like
Modals should be responsive to the amount of space available

Describe alternatives you've considered
We're already using the largest modal size (modal--large), an alternative approach would be to provide modal sizes above large

Additional context
An example modal where the labels are squeezed
Screenshot 2022-05-25 at 12 29 58

@Stanton Stanton self-assigned this May 25, 2022
@Stanton
Copy link
Member

Stanton commented May 25, 2022

Responsive modal is the easy bit, the illustrated problem mostly requires a responsive form layout which is a significantly bigger challenge...

@Stanton
Copy link
Member

Stanton commented May 25, 2022

@theGreener Any chance you can DM me the contents of that modal as test data?

@Stanton Stanton linked a pull request Aug 25, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants