Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MATLAB to GitHub Actions #103

Open
KrisThielemans opened this issue Dec 30, 2021 · 5 comments
Open

add MATLAB to GitHub Actions #103

KrisThielemans opened this issue Dec 30, 2021 · 5 comments

Comments

@KrisThielemans
Copy link

@traversaro a reminder that you volunteered to add GHA support for MATLAB (see #96 (comment)_). However, swig/master has had recent updates to the GHA workflow which aren't in #96 at present, so you probably want to hang a bit longer.

@traversaro
Copy link

@KrisThielemans thanks for the remainder! Feel free to let me know when you think that #96 is ready to be modified with MATLAB support in GitHub Actions.

@KrisThielemans
Copy link
Author

I believe #96 is now ready for this, as I've merged swig/master again. However, I suggest that @jaeandersson first merges #96, and you create a separate PR for a few reasons:

  • you could do a PR on mine, but we'd have a 4 levels of PRs
  • sorting out GHA in my experience takes about 50 commits anyway, which would make the history of Matlab update #96 a mess. A separate PR for GHA would allow a squash-merge.

Of course, I guess you could start with this already anyway. as you prefer

@jaeandersson
Copy link
Owner

Thanks and sorry for not staying on top of this. A bit overwhelmed with other work, a toddler and a baby at the moment. I've put aside time to work on this the second week of January.

@traversaro
Copy link

traversaro commented Jan 3, 2022

Work ongoing on traversaro#1 (temporary PR just to run the CI somewhere).

@traversaro
Copy link

After some iterations, the CI at traversaro#1 has the test working.
Current open points:

  • There are a lot of warnings like Warning: invalid MATLAB symbol '_val' (variable) during test
  • The clean step is failing
  • All the other languages compile with -Werror, but doing that in MATLAB fails with errors warning: ISO C90 forbids mixed declarations and code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants