Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Request more fine-grained control for remote sampling #106

Open
garrettlish opened this issue Sep 10, 2024 · 2 comments
Open

Comments

@garrettlish
Copy link

Requirement

As a Jaeger remote sampling protocol user, I want more fine-grained control for remote sampling so that we can enforce sampling for a particular user session.

Problem

The PerOperationSampler provides operation-level customized sampling probabilities but lacks support for more fine-grained control, such as adjusting sampling probabilities based on specific tag key-value pairs (see sampling.proto).

For instance, in a real-world scenario, we might want to enforce sampling for a particular user session by customizing sampling probabilities based on specific tag key-value pairs.

Proposal

Introduce a tag key-value pair in OperationSamplingStrategy to enable fine-grained control for remote sampling.

Open questions

No response

@yurishkuro
Copy link
Member

This isn't a Jaeger issue anymore - just extending the schema is not enough, the OTEL SDKs need to understand the more complex partitioning. There are some PRs in OTEL that are trying to address having more flexible sampling expressions, but none of them were merged iirc.

@garrettlish
Copy link
Author

Thanks @yurishkuro, filed open-telemetry/opentelemetry-go-contrib#6127 in open-telemetry community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants