Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api_v2] Change time fields in ArchiveTraceRequest to non-nullable for gogo #113

Conversation

rim99
Copy link
Contributor

@rim99 rim99 commented Nov 25, 2024

Which problem is this PR solving?

Part of jaegertracing/jaeger#4150

Description of the changes

  • Make sure type of time fields are aligned with other requests

How was this change tested?

  • unit test

Checklist

@yurishkuro yurishkuro changed the title update type of time fields of api_v2 ArchiveTraceRequest [api_v2] Change time fields in ArchiveTraceRequest to non-nullable for gogo Nov 25, 2024
@yurishkuro yurishkuro merged commit de97430 into jaegertracing:main Nov 25, 2024
2 checks passed
@yurishkuro
Copy link
Member

Let's make a small PR in /jaeger/ that only imports this IDL change and regenerates .pb.go

yurishkuro pushed a commit to jaegertracing/jaeger that referenced this pull request Nov 25, 2024
…6251)

## Which problem is this PR solving?
Part of #4150

## Description of the changes
- related to jaegertracing/jaeger-idl#113

## How was this change tested?
- unit test

Signed-off-by: rim99 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants