Skip to content
This repository has been archived by the owner on May 18, 2020. It is now read-only.

Sidecar example spec using deprecated argument #115

Open
gmankes opened this issue Feb 28, 2019 · 3 comments
Open

Sidecar example spec using deprecated argument #115

gmankes opened this issue Feb 28, 2019 · 3 comments
Labels

Comments

@gmankes
Copy link

gmankes commented Feb 28, 2019

Requirement - what kind of business use case are you trying to solve?

I am attempting to use jaeger tracing to observe into the applications at my company. The attempt is to use the jaeger agent as a sidecar, and send the traces to a collector in a separate namespace.

Problem - what in Jaeger blocks you from solving the requirement?

The argument provided to the jaeger agent --collector.host-port=jaeger-collector.jaeger-infra.svc:14267 is deprecated, leading to the jaeger agent to crash on boot due to lack of address. The error: could not create collector proxy, address is missing

Proposal - what do you suggest to solve the problem or improve the existing situation?

Change the argument to the sidecar jaeger agent to ["--reporter.type=tchannel", "--reporter.tchannel.host-port=jaeger-collector.jaeger-infra.svc:14267"]

@jpkrohling
Copy link
Collaborator

@pavolloffay shouldn't these options be still recognized? If we broke backwards compatibility here, we need to change the OpenShift templates and Operator as well.

@jpkrohling jpkrohling added the bug label Mar 1, 2019
@pavolloffay
Copy link
Member

This happens with latest image and it's related to jaegertracing/jaeger#1395 (comment). I have proposed a solution to not break users.

@pavolloffay
Copy link
Member

I would rather change the reporter to grpc in our deployments.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants