Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Drop Support For Same Host Ports #6117

Open
mahadzaryab1 opened this issue Oct 23, 2024 · 2 comments
Open

[query] Drop Support For Same Host Ports #6117

mahadzaryab1 opened this issue Oct 23, 2024 · 2 comments
Labels
area/otel changelog:breaking-change Change that is breaking public APIs or established behavior enhancement

Comments

@mahadzaryab1
Copy link
Collaborator

mahadzaryab1 commented Oct 23, 2024

Requirement

This issue can be tackled after Feb 2025.

In #6026, the query server was migrated to use OTEL's implementation of HTTP and GRPC servers. Our implementation supported having the GRPC and HTTP server being hosted on the same port via cmux, however, OTEL's implementation does not support this. For backwards compatibility purposes, #6026 did not drop support for the same ports but rather just logged a warning to allow users to migrate away from this functionality. Once we have waited for three months or two minor version bumps (whichever is later), we can drop support for hosting grpc and query server on the same port.

@dosubot dosubot bot added area/otel changelog:breaking-change Change that is breaking public APIs or established behavior labels Oct 23, 2024
@abuzaforfagun
Copy link

I am interested in working on this issue.

@yurishkuro yurishkuro removed the good first issue Good for beginners label Oct 24, 2024
@yurishkuro
Copy link
Member

This is aimed for Feb 2025, not earlier, per our deprecation policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/otel changelog:breaking-change Change that is breaking public APIs or established behavior enhancement
Projects
None yet
Development

No branches or pull requests

3 participants