[query] Enable trace adjusters in api_v2 and api_v3 handlers #6423
+161
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
added
the
changelog:breaking-change
mahadzaryab1
commented
Dec 27, 2024
Signed-off-by: Mahad Zaryab <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6423 +/- ##
==========================================
+ Coverage 96.23% 96.26% +0.02%
==========================================
Files 368 368
Lines 21028 21032 +4
==========================================
+ Hits 20237 20246 +9
+ Misses 606 602 -4
+ Partials 185 184 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Dec 27, 2024
cmd/query/app/http_handler.go
Outdated
| aH.writeJSON(w, r, structuredRes) | ||
| } | ||
|
|
||
| func shouldAdjust(r *http.Request) bool { | ||
| func shouldUseRawTraces(r *http.Request) bool { | ||
| raw := r.FormValue("raw") |
There was a problem hiding this comment.
Need to add tests with/without this arg. Also, since it's optional, should you be calling ParseBool unconditionally on it?
There was a problem hiding this comment.
@yurishkuro This was the existing behaviour. It looks like we ignored anything that wasn't true. Do we want to change that here?
There was a problem hiding this comment.
yes, I would make it more strict.
There was a problem hiding this comment.
do we want the api to return an error here if the parameter isn't explicitly true or false?
There was a problem hiding this comment.
I think it's ok to be flexible similar to https://pkg.go.dev/strconv#ParseBool. I.e. t or 1 are fine, but fooobar should return an error.
Signed-off-by: Mahad Zaryab <[email protected]>
2 tasks
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Dec 27, 2024
cmd/query/app/http_handler_test.go
Outdated
| ts.spanReader.On("GetTrace", mock.AnythingOfType("*context.valueCtx"), spanstore.GetTraceParameters{TraceID: model.NewTraceID(0, 0x123456abc)}). | ||
| ts.spanReader.On("GetTrace", mock.AnythingOfType("*context.valueCtx"), spanstore.GetTraceParameters{ | ||
| TraceID: model.NewTraceID(0, 0x123456abc), | ||
| RawTraces: testCase.suffix == "?raw=true", |
There was a problem hiding this comment.
it's better to have a field raw bool in the testCase
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Dec 27, 2024
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
4 tasks
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
commented
Dec 29, 2024
mahadzaryab1
changed the title
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
approved these changes
Dec 29, 2024
yurishkuro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
FindTracesrequest, set the raw_traces flag in the query parameters totrue.GetTracerequest, set the raw_traces flag in the request totrue.FindTracesrequest, set the raw_traces flag in the query parameters totrue.GetTracerequest, set the raw_traces flag in the request totrue.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test