ready for julia 1.10 #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kind reminder: Julia 1.10 is coming closer it would be nice if you could look into this your package is a downward compatibility of my package and prevents it from passing tests |
Closed
|
@jagot Do you have time to look at this? I'm currently on parental leave with very limit time on my hands. :) |
|
Sorry for missing this PR, I will try to take a look at it during the weekend. |
Merged
|
Merged in #13, thank you! I wanted to revert parts of the CI config, since if we declare compatibility with Julia 1.4, we better test on that version too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SparseArrays doesnt have AdjOrTransDenseMatrix anymore in julia 1.10
here is a fix to get it to work