Buffer fix #10
Merged
Buffer fix #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julia 1.7.x introduced _goodbuffers and _checkbuffers but use them incorrectly for AbstractSparseArrays. This is fixed on 1.8, but we need a workaround in 1.7.x. Also fixed bug where copy(X'), copy(transpose(X)) and permutedims(X) didn't return ThreadedSparseMatrixCSC.
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
- Coverage 98.91% 89.56% -9.35%
==========================================
Files 1 1
Lines 92 115 +23
==========================================
+ Hits 91 103 +12
- Misses 1 12 +11
Continue to review full report at Codecov.
|
Simplify code by @eval loop for copy and permutedims. Add unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #9.
Also keep type when copying adjoint or transpose or using permutedims.