Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize on Weld release for a 4.1.0.Beta1 TCK release #539

Closed
starksm64 opened this issue Feb 15, 2024 · 9 comments
Closed

Synchronize on Weld release for a 4.1.0.Beta1 TCK release #539

starksm64 opened this issue Feb 15, 2024 · 9 comments
Assignees
Milestone

Comments

@starksm64
Copy link
Contributor

I would like to synch on a Weld release that picks up the 4.1.0.Beta1 cdi api update so we can produce a 4.1.0.Beta1 cdi tck that includes the outstanding PRs. I merged #518 assignability tests, #502 looks ready, and then #532 should be ready.

@manovotn
Copy link
Contributor

Yes, I intend to work on that next.

#502 should definitely get in - I will be focusing on getting that working in Weld next.
As for #532, I am not sure that should be in TCK Beta1 as the CDI API Beta1 doesn't contain the spec text removal either (https://github.com/jakartaee/cdi/commits/main/).
Either way, that should be a minor thing WRT to having a passing impl anyway.

@starksm64
Copy link
Contributor Author

That is fine, I can do a Beta 2 that just has the integration spec/tck removals next week.

@starksm64 starksm64 added this to the CDI 4.1 milestone Feb 22, 2024
@starksm64
Copy link
Contributor Author

@manovotn Is there an ETA for the next Weld release? Is there anything you need help with?

@manovotn
Copy link
Contributor

manovotn commented Feb 25, 2024

I was preoccupied elsewhere, I am working on it now.

The list of known issues is over at JIRA but I will shift most of them past Beta to get a release out ASAP. [EDIT: I have shifted most to Beta2 already]
I already have release of Weld parent and Beta of Weld API and I am working on a PR for core - weld/core#2911.

It is all built against M1 TCK (although I tested locally against master) as I tried to create a Beta TCK release yesterday but Jenkins probably had some maintenance and was inaccessible. Doesn't really matter though.

Is there anything you need help with?

I think I can handle the Beta fine but if you want to help past that, I could use a hand with re-configuring the testing setup in Weld once the TCK web module gets migrated into platform TCKs. I assume this will happen for RC release, right?

@manovotn
Copy link
Contributor

I think I should be able to get the release out tomorrow.

@starksm64
Copy link
Contributor Author

I think I can handle the Beta fine but if you want to help past that, I could use a hand with re-configuring the testing setup in Weld once the TCK web module gets migrated into platform TCKs. I assume this will happen for RC release, right?

Removal from the CDI TCK will happen after Beta1, which I'll do as soon as there is a new Weld release. I'll do an RC1 right after that has the Jakarta EE integration concerns in the spec and TCK removed. We are supposed to be targeting a final release this coming week.

@manovotn
Copy link
Contributor

@starksm64 Weld 6.0.0.Beta1 should be syncing to Central right now.

@starksm64
Copy link
Contributor Author

I see it, working on the TCK release now.

@starksm64
Copy link
Contributor Author

The 4.1.0.Beta1 TCK has been pushed out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants