Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release]: Milestone 1.0.0-M3 #415

Closed
23 tasks done
KyleAure opened this issue Jan 8, 2024 · 13 comments · Fixed by #481
Closed
23 tasks done

[Release]: Milestone 1.0.0-M3 #415

KyleAure opened this issue Jan 8, 2024 · 13 comments · Fixed by #481
Assignees
Labels
release Issue that proposes a new release

Comments

@KyleAure
Copy link
Contributor

KyleAure commented Jan 8, 2024

Proposal

There have been additional changes to the API and TCK that will require an additional milestone release.

Outstanding work

Anything else we need to go into Milestone 3?

Check List

Prepare

  • Open this issue.
  • Complete outstanding work
  • (Update TCK Signatures to capture API changes)[https://github.com/jakartaee/data/actions/workflows/release.yml]

Stage release

Verify and modify

  • Ask for feedback from the community to verify the staged artifact has all the expected changes.
  • If anything needs to be added before publishing do that now and repeat the Stage Release section

Publish release

Follow up

@KyleAure KyleAure added the release Issue that proposes a new release label Jan 8, 2024
@KyleAure KyleAure self-assigned this Jan 8, 2024
@njr-11
Copy link
Contributor

njr-11 commented Jan 8, 2024

Excellent idea to create a Milestone 3 given the updates! We should have a final answer regarding the last issue in the list, #394, on Wednesday, Jan 17 if everyone attends the Jakarta Data meeting that day.

@KyleAure
Copy link
Contributor Author

KyleAure commented Jan 30, 2024

Milestone 3 is staged:

@njr-11 @otaviojava I know there was some more refinement needed for the static metamodel based on the comments on #394. Let me know if you think any of that should go into milestone 3, otherwise, I can go ahead and publish it.

Status:

@KyleAure
Copy link
Contributor Author

Milestone 3 is re-staged:

FYI - @njr-11 @otaviojava let me know if this looks good and I go ahead and publish the release.

@lprimak
Copy link
Contributor

lprimak commented Feb 21, 2024

Please use "Release Drafts" to indicate that the release is not public. Currently, it looks like M3 is released on GitHub but it's not in Maven Central.

Thank you!

@KyleAure
Copy link
Contributor Author

KyleAure commented Feb 21, 2024

@lprimak I marked 1.0.0-M3 as pre-release I figured that would indicate it hasn't been released yet. Perhaps I misunderstood what the use case of pre-release would be.

@lprimak
Copy link
Contributor

lprimak commented Feb 21, 2024

Either you or me :)
I always thought that pre-release was alpha, beta, etc. and it's all "deployed" in central but not considered a "final" release.

@KyleAure
Copy link
Contributor Author

Ahh. I can change this process to use drafts instead. I assume you get a notification if I mark it pre-release?

@lprimak
Copy link
Contributor

lprimak commented Feb 22, 2024

Thanks Kyle!
Yes, I got a notification and assumed that it was (or would shortly be) on Maven Central.
I also updated Jakarta EE platform to use it.
Is M3 going to be released soon or would I need to revert the Jakarta EE platform change to use M2 instead?
If M3 going to be released soon, I will just leave it alone as Platform M2 isn't scheduled for another few weeks I think

@KyleAure
Copy link
Contributor Author

I believe there is just one more doc change that needs to go in and then I'll go forward with a stage/release.

@gavinking
Copy link
Contributor

gavinking commented Feb 22, 2024

@KyleAure I don't think #474 should block the release. We have not reached consensus on it.

@KyleAure
Copy link
Contributor Author

Milestone 3 is re-staged:

FYI - @gavinking @otaviojava @njr-11 @lprimak I'll test this against Open Liberty tomorrow and push to maven central so long as there are no other changes y'all want to be put in (that can't wait for M4)

@KyleAure
Copy link
Contributor Author

Milestone 3 is released 🚀 :

@gavinking
Copy link
Contributor

gavinking commented Feb 23, 2024

Nice!

And now that it's available, I have already made an excellent start on an implementation!

hibernate/hibernate-orm#7888

The main challenge is going to be the keyset-based pagination stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issue that proposes a new release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants