Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importConstants should be allowed everywhere, not only in f:metadata #1466

Open
eclipse-faces-bot opened this issue Apr 9, 2018 · 9 comments
Milestone

Comments

@eclipse-faces-bot
Copy link

In big and modular applications, it's to complex to import all enums via f:metadata.
Every CC or include should be able to maintain their own imports, otherwise its very hard to maintain.

@eclipse-faces-bot
Copy link
Author

@BalusC Commented
Agreed and this is also how <o:importConstants> behaves, but the 2.3 EG decided so.

@eclipse-faces-bot
Copy link
Author

@tandraschko Commented
I see :/ But we could talk about it again for the next version, right?

@eclipse-faces-bot
Copy link
Author

@tandraschko
Copy link

IMO important for JSF3

@tandraschko tandraschko added this to the 4.1 milestone Jun 9, 2022
@tandraschko
Copy link

related to #1683

@volosied
Copy link
Contributor

volosied commented Jul 7, 2023

Should this be a general f:metadata revsion? Nice if the spec could be updated to handle eclipse-ee4j/mojarra#5105

@volosied
Copy link
Contributor

The omnifaces documentation lists that the o:importConstants saves the objects in the request scope. Should this approach also be taken by the spec / impls?

@volosied
Copy link
Contributor

volosied commented Oct 12, 2023

Few questions:

  1. Should ViewMetadata#getImportConstants change or should it still return the list of import constants?

  2. Should this tag keep the same taglib uri (jakarta.faces.core) and just simply be allowed to be placed anywhere? Or should a new tag be created?

@BalusC
Copy link
Member

BalusC commented Nov 4, 2023

Let's move to 5.0 for now. We can then take the opportunity to reconsider the f:metadata. Also related: #1849

@tandraschko tandraschko modified the milestones: 4.1, 5.0 Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants