Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript type is any #181

Open
clickBi opened this issue Feb 3, 2022 · 5 comments
Open

TypeScript type is any #181

clickBi opened this issue Feb 3, 2022 · 5 comments
Labels

Comments

@clickBi
Copy link

clickBi commented Feb 3, 2022

Hi,
I get this error:
Error: src/app/runDashboard/custom-items/funnel.ts:10:26 - error TS7016: Could not find a declaration file for module 'd3-funnel'. '../node_modules/d3-funnel/dist/d3-funnel.js' implicitly has an 'any' type.
Try npm i --save-dev @types/d3-funnel if it exists or add a new declaration (.d.ts) file containing declare module 'd3-funnel';
How to fix it?

@jakezatecky
Copy link
Owner

I am not very familiar with TypeScript as I do not use it. I merged in a TypeScript index file at the request of another contributor but if anyone else has an idea of what may be causing this issue I am open to merging a fix.

@fregante
Copy link

Can you release a new version? The file was added in July but the last release was in June

@jakezatecky
Copy link
Owner

I released a new version with the TypeScript index file. Do not know if this will resolve things for TypeScript users.

@fregante
Copy link

fregante commented Nov 5, 2023

Thank you! That silenced the error but unfortunately that still has no types. It'd be great to see this library typed.

@jakezatecky
Copy link
Owner

I am open to any pull request makes the project more accessible to TypeScript users. As I do not use TypeScript myself, I am not exactly familiar with the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants