-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--zoom
is ignored and defaults to 1
#20
Comments
Correct, invalid zooms default to 1... Infrared only supports up to 3 :) I'm working on getting |
this is what open source is about! |
So, to your misfortune, IR is only up to 3 zoom levels (that I could discern), would you consider this a non-issue? |
Yep but you should use |
Roger that. What experience would you like, for it to throw an err or exit if the options are invalid? |
yep console.error + process.exit(1). if you use a args parser they handle this for you and follow all best practices. I'll suggest you look into |
Catching this issue with the behavior you're suggesting above is already possible with the current setup (minimist + cliclopts). See optimist for the yargs/minimist origin story :)
|
With:
--zoom
is ignored and defaults to 1. using latestThis my last attempt for today 🍻
The text was updated successfully, but these errors were encountered: