Updated linting errors and workflow file

Author: jakottelaar

.github/workflows/workflow.yml

@@ -9,7 +9,7 @@ on:
       - main
 
 jobs:
-  build:
+  lint:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -24,10 +24,13 @@ jobs:
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
-      - name: Build
-        run: go build -v ./...
+      - name: Lint
+        uses: golangci/golangci-lint-action@v3
+        with:
+          version: latest
 
-  lint:
+  build:
+    needs: lint
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -42,12 +45,16 @@ jobs:
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
-      - name: Lint
-        uses: golangci/golangci-lint-action@v3
+      - name: Build
+        run: go build -v ./...
+      - name: Upload build artifact
+        uses: actions/upload-artifact@v3
         with:
-          version: latest
+          name: app-binary
+          path: ./your-app-binary-name
 
   test:
+    needs: build
     runs-on: ubuntu-latest
     services:
       postgres:
@@ -77,6 +84,10 @@ jobs:
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
+      - name: Download build artifact
+        uses: actions/download-artifact@v3
+        with:
+          name: app-binary
       - name: Install golang-migrate
         run: go install -tags 'postgres' github.com/golang-migrate/migrate/v4/cmd/migrate@latest
       - name: Run Migrations

api/routes.go

@@ -30,7 +30,11 @@ func SetupRoutes() *chi.Mux {
 
 	// Health check
 	r.Get("/health", func(w http.ResponseWriter, r *http.Request) {
-		common.WriteJSON(w, http.StatusOK, common.Envelope{"message": "Health Check OK"}, nil)
+		err := common.WriteJSON(w, http.StatusOK, common.Envelope{"message": "Health Check OK"}, nil)
+		if err != nil {
+			common.ServerErrorResponse(w, r, err)
+			return
+		}
 	})
 
 	// API routes

internal/book/handler.go

@@ -67,8 +67,11 @@ func (h *BookHandler) CreateBook(w http.ResponseWriter, r *http.Request) {
 		CreatedAt:     createdBook.CreatedAt,
 	}
 
-	common.WriteJSON(w, http.StatusCreated, common.Envelope{"book": resp}, nil)
-
+	err = common.WriteJSON(w, http.StatusCreated, common.Envelope{"book": resp}, nil)
+	if err != nil {
+		common.ServerErrorResponse(w, r, err)
+		return
+	}
 }
 
 // GetBookById godoc
@@ -110,8 +113,11 @@ func (h *BookHandler) GetBookById(w http.ResponseWriter, r *http.Request) {
 		UpdatedAt:     book.UpdatedAt,
 	}
 
-	common.WriteJSON(w, http.StatusOK, common.Envelope{"book": resp}, nil)
-
+	err = common.WriteJSON(w, http.StatusOK, common.Envelope{"book": resp}, nil)
+	if err != nil {
+		common.ServerErrorResponse(w, r, err)
+		return
+	}
 }
 
 // UpdateBook godoc
@@ -177,8 +183,11 @@ func (h *BookHandler) UpdateBook(w http.ResponseWriter, r *http.Request) {
 		CreatedAt:     book.CreatedAt,
 	}
 
-	common.WriteJSON(w, http.StatusOK, common.Envelope{"book": resp}, nil)
-
+	err = common.WriteJSON(w, http.StatusOK, common.Envelope{"book": resp}, nil)
+	if err != nil {
+		common.ServerErrorResponse(w, r, err)
+		return
+	}
 }
 
 // DeleteBook godoc
@@ -210,6 +219,9 @@ func (h *BookHandler) DeleteBook(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	common.WriteJSON(w, http.StatusOK, common.Envelope{"message": "Successfully deleted book"}, nil)
-
+	err = common.WriteJSON(w, http.StatusOK, common.Envelope{"message": "Successfully deleted book"}, nil)
+	if err != nil {
+		common.ServerErrorResponse(w, r, err)
+		return
+	}
 }

pkg/common/helpers.go

@@ -36,8 +36,7 @@ func WriteJSON(w http.ResponseWriter, status int, data Envelope, headers http.He
 
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(status)
-	w.Write(js)
-
+	_, _ = w.Write(js)
 	return nil
 }