Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port rules over from eslint-plugin-redux-saga? #4

Open
dejesus2010 opened this issue Nov 28, 2021 · 2 comments
Open

Port rules over from eslint-plugin-redux-saga? #4

dejesus2010 opened this issue Nov 28, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@dejesus2010
Copy link
Contributor

Hi there, any chance you can port over the rules in eslint-plugin-redux-saga? Particularly the yield-effect rule.

I just started using redux-saga (well, typed-redux-saga) and I'm finding myself forgetting to prefix effect calls with yield.
@dejesus2010
Copy link
Contributor Author

I actually went ahead and added support for this in a PR #5 I just submitted

@SantoJambit SantoJambit added the enhancement New feature or request label Dec 1, 2021
@SantoJambit
Copy link
Contributor

Hey, while going over the code again, I am a bit confused about the tests for yield-effects. According to the tests, using yield take('ACTION') is okay. Should this not be yield*?

I don't think a rule that only makes sure "yield" is used, makes sense for this project

@lourd lourd mentioned this issue Jan 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds documentation for yield-effects rule
2 participants
@dejesus2010 @SantoJambit