Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade win-detect-browsers to v2 #71

Open
dtanp opened this issue May 15, 2018 · 2 comments
Open

Upgrade win-detect-browsers to v2 #71

dtanp opened this issue May 15, 2018 · 2 comments

Comments

@dtanp
Copy link

dtanp commented May 15, 2018

Firefox isn't detected on Windows 10. Upgrade to use win-detect-browsers v2 and the issue is fixed.

Reproduce steps:

  • Install Firefox latest (v60)
  • Run /example/detect.js
  • Only chrome and ie show in console.

Solution:

Try to upgrade win-detect-browsers module to v2 and run the detect.js again, Firefox will show in the list.

@mitchhentges Would it be possible to use the new version of web-detect-browsers instead?

@mitchhentges
Copy link
Member

win-detect-browsers 2 is out? Nice!

I'm a little knee-deep in other commitments right now to work on this, but a PR would be welcome!

@dtanp
Copy link
Author

dtanp commented May 17, 2018

@mitchhentges Cool. I've just created the PR. Please help to review when you are free :)

Many thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants