Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No replace in json files #74

Open
aclayton opened this issue Jun 9, 2017 · 4 comments
Open

No replace in json files #74

aclayton opened this issue Jun 9, 2017 · 4 comments

Comments

@aclayton
Copy link

aclayton commented Jun 9, 2017

gulp-rev-replace doesn't seem to be accepting .json files, even when adding 'json' to the replaceInExtensions options. This is to support versioning of pwa manifest.json files.

Paths check out (via console)
see my gulp task below.

gulp.task('revReplaceManifest', function() {
  
  console.log('REV Manifest: ', `${paths.dist}/${paths.client.revManifest}`);
  console.log('PWA Manifest: ', 'dist/client/manifest.json');

  return gulp.src('dist/client/manifest.json')
      .pipe(plugins.revReplace({
        replaceInExtensions: ['.json'],
        manifest: gulp.src(`${paths.dist}/${paths.client.revManifest}`)
      }))
      .pipe(gulp.dest('dist/client'));
});
@auban
Copy link

auban commented Mar 27, 2018

Same problem

@simondib
Copy link

+1

1 similar comment
@lipichang
Copy link

+1

@TheDancingCode
Copy link
Contributor

Could any of you set up a small repo with the bare minimum to reproduce the problem? In all of the cases I've tried, replacement in JSON files seems to work just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants