Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't replace URI-encoded file name including non-ascii characters #79

Open
zacky1972 opened this issue Dec 25, 2017 · 1 comment
Open

Can't replace URI-encoded file name including non-ascii characters #79

zacky1972 opened this issue Dec 25, 2017 · 1 comment

Comments

@zacky1972
Copy link

Now rev-replace can't replace URI-encoded file name including non-ascii characters such that: %e6%97%a5%e6%9c%ac%e8%aa%9e.jpg
zacky1972 added a commit to zacky1972/gulp-rev-replace that referenced this issue Dec 25, 2017
@zacky1972
fix jamesknelson#79
f7da97a
zacky1972 added a commit to zacky1972/gulp-rev-replace that referenced this issue Dec 25, 2017
@zacky1972
Merge pull request #2 from zacky1972/zacky1972-url-encode
606d566 
fix jamesknelson#79
@TheDancingCode
Copy link
Contributor

Do you mean a situation where you have a file 日本語.jpg and a uri-encoded reference to it in your html like %e6%97%a5%e6%9c%ac%e8%aa%9e.jpg? Because in that case you could use the modifyUnreved/Reved functions. In what sense is the problem specific to non-ascii characters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zacky1972 @TheDancingCode