Skip to content

Commit 0bfbb87

Browse files
committed
Hide internal decorator disposeBy, to allow client to use typescript 4 (#48)
Since the decorator-related classes were introduced from typescript 5.0
1 parent ada78eb commit 0bfbb87

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/disposable.mts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ export abstract class XmlDisposable implements Disposable {
1717
* Alias of {@link "[dispose]"}.
1818
*
1919
* @see {@link "[dispose]"}
20-
* @see {@link disposeBy}
2120
*/
2221
dispose(): void {
2322
const metadata = (this.constructor as any)[Symbol.metadata];
@@ -37,7 +36,6 @@ export abstract class XmlDisposable implements Disposable {
3736
* or declare the object with `using` declaration.
3837
*
3938
* @see {@link dispose}
40-
* @see {@link disposeBy}
4139
*/
4240
[Symbol.dispose](): void {
4341
this.dispose();
@@ -49,6 +47,7 @@ export abstract class XmlDisposable implements Disposable {
4947
*
5048
* @param free function to release the managed wasm resource
5149
* @returns the decorator
50+
* @internal
5251
*/
5352
export function disposeBy<This extends XmlDisposable>(free: (value: Pointer) => void) {
5453
return function decorator(

test/disposable.spec.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { expect } from 'chai';
2-
import { disposeBy, XmlDisposable } from '../lib/disposable.mjs';
2+
import { disposeBy, XmlDisposable } from '../src/disposable.mjs';
33

44
function fixture(free1: number[], free2: number[]) {
55
return class Fixture extends XmlDisposable {

0 commit comments

Comments
 (0)