Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create IOReader #161

Open
giacomocaironi opened this issue Jul 12, 2024 · 2 comments
Open

Can't create IOReader #161

giacomocaironi opened this issue Jul 12, 2024 · 2 comments

Comments

@giacomocaironi
Copy link

I am trying to read from std::io::Read using CRC. As this feature in not standard I am trying to use Flavors.
However, I can't create an IOReader as its new() constructor is a private associated function, and if I try to crate the struct directly I can't because I need a SlidingBuffer, which is a private struct.
There is a reason why this is the case or am I missing something?

@jamesmunns
Copy link
Owner

Hi @giacomocaironi, I'm not too familiar with the IOReader, maybe @xgroleau has an idea?

@xgroleau
Copy link
Contributor

xgroleau commented Jul 12, 2024

Hey @giacomocaironi and @jamesmunns I don't see the reason why I've put IOReader new as private..... Probably overlooked it since I did not compose them with other flavors for my usecase.
I think we could just put the newfrom IOReader and EIOReader as public which would allow the user to compose the flavors as he see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants