Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultvalues argument on newidfobject #215

Open
peterrwilson99 opened this issue Mar 8, 2021 · 1 comment
Open

defaultvalues argument on newidfobject #215

peterrwilson99 opened this issue Mar 8, 2021 · 1 comment
Assignees
@jamiebull1
Labels
bug

Comments

@peterrwilson99
Copy link

peterrwilson99 commented Mar 8, 2021 •
edited
Loading

Currently, the patches.py implementation of newidfobject removes the argument of defaultvalues, to not add default values to an idf object. With the example of 'Daylighting:Controls', it will edit reference points that do not exist causing EnergyPlus to fail.

Screen_Shot_2021-02-24_at_12 50 19_PM

Screen_Shot_2021-02-24_at_12 51 43_PM
@arjunrdesai
Copy link

Facing the same issue. Is there a solution to this? Kindly guide me for the solution

@jamiebull1 jamiebull1 added the bug label Nov 11, 2022
@jamiebull1 jamiebull1 mentioned this issue Nov 11, 2022
Merged
@jamiebull1 jamiebull1 self-assigned this Nov 16, 2022
jamiebull1 added a commit that referenced this issue Nov 16, 2022
@jamiebull1
Keeps the defaultvalues kwarg, and passes it through to newrawobject (#…
2aa9ee4 
…247)

fixes #215 

Co-authored-by: Jamie Bull <[email protected]>
jamiebull1 added a commit that referenced this issue Nov 16, 2022
@jamiebull1
Keeps the defaultvalues kwarg, and passes it through to newrawobject (#…
4b37a2b 
…247)

fixes #215 

Co-authored-by: Jamie Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamiebull1 jamiebull1

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jamiebull1 @peterrwilson99 @arjunrdesai