Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to look into adding target locations for the JsonbNillable annotation #52

Open
jansupol opened this issue Aug 30, 2017 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@jansupol
Copy link
Owner

While running a hands-on-lab with people wanting to get acquainted with JSON-B a number of participants attempted to apply the @JsonbNillable in places where the @JsonbProperty with boolean nillable should be used.

While the javadocs on @JsonbNillable point in the right direction for the desired functionality, for some people this is not quite intuitive.

Could this be made easier on new JSON-B users by making the annotation @JsonbNillable applicable to places where @JsonbProperty should now be used, or would there be objections making this not feasible/desirable?

@jansupol
Copy link
Owner Author

jansupol commented Oct 4, 2017

@bravehorsie Commented
That will introduce problem with ambiguous configuration, for example:
@JsonbProperty(nillable=false)
@JsonbNillable
Strig property;

So which nillable takes precedence here? Please note we can't check if both are set to raise exception in that case because of @JsonbProperty default nillable value for example when declared as @JsonbProperty("propName") it defaults to false.

@jansupol
Copy link
Owner Author

@jansupol jansupol added the enhancement New feature or request label May 23, 2018
@jansupol jansupol added this to the 2.0 milestone May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant