Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No plugin configuration found at undefined #2627

Open
jkilzi opened this issue Feb 1, 2025 · 0 comments
Open

No plugin configuration found at undefined #2627

jkilzi opened this issue Feb 1, 2025 · 0 comments
Labels

Comments

@jkilzi
Copy link
Member

jkilzi commented Feb 1, 2025

No plugin configuration found at undefined create this file as needed if this plugin requires configuration

This message is logged when executing yarn dlx @janus-idp/cli package package-dynamic-plugins ... and when no app-config.janus-idp.yaml file is found.

Searching for the string, I discovered it is produced here.

I believe this message is confusing for users and is also a bug.
First, I believe this is a bug because the log is produced inside an if-else statement, specifically the condition checks if the variable containing the path to this file is not undefined, therefore using this variable in the else part of the statement will always be undefined.
Second, how is this message helpful? How could one ever know that having the app-config.janus-idp.yaml file around when executing this command would be useful?. I beleive that if the command can do something useful with this file then it should be mentioned somewhere in the docs or perhaps explain the situation when this same message is logged.

NB: Perhaps this is related to: #1146

@github-actions github-actions bot added the jira label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant