You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No plugin configuration found at undefined create this file as needed if this plugin requires configuration
This message is logged when executing yarn dlx @janus-idp/cli package package-dynamic-plugins ... and when no app-config.janus-idp.yaml file is found.
Searching for the string, I discovered it is produced here.
I believe this message is confusing for users and is also a bug.
First, I believe this is a bug because the log is produced inside an if-else statement, specifically the condition checks if the variable containing the path to this file is not undefined, therefore using this variable in the else part of the statement will always be undefined.
Second, how is this message helpful? How could one ever know that having the app-config.janus-idp.yaml file around when executing this command would be useful?. I beleive that if the command can do something useful with this file then it should be mentioned somewhere in the docs or perhaps explain the situation when this same message is logged.
This message is logged when executing
yarn dlx @janus-idp/cli package package-dynamic-plugins ...
and when noapp-config.janus-idp.yaml
file is found.Searching for the string, I discovered it is produced here.
I believe this message is confusing for users and is also a bug.
First, I believe this is a bug because the log is produced inside an if-else statement, specifically the condition checks if the variable containing the path to this file is not undefined, therefore using this variable in the else part of the statement will always be undefined.
Second, how is this message helpful? How could one ever know that having the
app-config.janus-idp.yaml
file around when executing this command would be useful?. I beleive that if the command can do something useful with this file then it should be mentioned somewhere in the docs or perhaps explain the situation when this same message is logged.NB: Perhaps this is related to: #1146
The text was updated successfully, but these errors were encountered: