Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

[API] Move runtime objects related configuration out of spec.Application #178

Closed
gazarenkov opened this issue Jan 31, 2024 · 2 comments
Closed
Labels
jira Issue will be sync'ed to Red Hat JIRA
Milestone

Comments

@gazarenkov
Copy link
Member

By idea, spec.Application section is for configuration Backstage Application container (app-configs, extra files, env vars...) and it is quite confusing to see configuration of workload k8s objects (such as replicas, network, image etc) here as well.

Proposal is to:

  • move backstage runtime configuration (image, replicas, image-pull secrets) on top level
  • move route to new Network section

So CR.spec would look like this:

spec:
  image: my-img
  imagePullSecrets: []
  replicas: 2
  application:
    appConfig: {}
    extraFiles: {}
    extraEnvs: {}
    dynamicPluginsConfigMapName: my-dp-cm
  database:
    enableLocalDb: true
  network:
   route: {}
@rm3l rm3l added the jira Issue will be sync'ed to Red Hat JIRA label Jan 31, 2024
@gazarenkov gazarenkov added this to the M3 milestone Feb 28, 2024
@gazarenkov
Copy link
Member Author

can be closed along with: #352

@nickboldt
Copy link
Member

As part of the migration from janus-idp to redhat-developer in https://issues.redhat.com/browse/RHIDP-1021, this will be tracked in https://issues.redhat.com/browse/RHIDP-1138

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
jira Issue will be sync'ed to Red Hat JIRA
Projects
None yet
Development

No branches or pull requests

3 participants